Backfill a few missing columns in equities.csv #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrote a quick script to backfill any missing columns in equities.csv. The script will keep any existing values, with the exception of market_cap. market_cap tended to be stale in several entries I looked at. The market_cap recomputation matches the update logic: https://github.com/JerBouma/FinanceDatabase/blob/main/.github/workflows/database_update.yml#L61-L77 The end goal of the script is to add missing any ISIN as it is keyed off of those. This PR contains only a small amount of changes to confirm the expected behavior and the desirability of running this further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote a quick script to backfill any missing columns in equities.csv. The script will keep any existing values, with the exception of market_cap. market_cap tended to be stale in several entries I looked at. The market_cap recomputation matches the update logic: https://github.com/JerBouma/FinanceDatabase/blob/main/.github/workflows/database_update.yml#L61-L77
The end goal of the script is to add missing any ISIN as it is keyed off of those.
This PR contains only a small amount of changes to confirm the expected behavior and the desirability of running this further.