Translation into Kotlin using Gradle's Provider interface #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps with editing because Kotlin is strongly typed among other benefits.
If it is null, it returns early so there is no need to check again.
VersionNumber has been deprecated so move to GradleVersion.
project.buildDir is deprecated so use the Provider interface now. This should be a step toward using Provider<Directory> everywhere instead of File directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at a solution for #41 I ended up rewriting the plugin in Kotlin and reorganizing everything to use the newer Gradle lazy configuration using Properties and Providers. Sorry for the huge change, but I got a little bit carried away.
I did not rewrite the the tests except to change
Path#newFiletoPath#resolvewith a call to a.toFile()call. For some reason the newer Gradle versions don't accept what the test was doing.java.nio.file.Path#newFiledoesn't exist so I'm not sure which type coercion was happening before.