Patch release 0.7.3 (#75)

* resolve problem with == #74
* bump to 0.7.3

Author: ablaom

Project.toml

@@ -1,7 +1,7 @@
 name = "MLJBase"
 uuid = "a7f614a8-145f-11e9-1d2a-a57a1082229d"
 authors = ["Anthony D. Blaom <[email protected]>"]
-version = "0.7.2"
+version = "0.7.3"
 
 [deps]
 CategoricalArrays = "324d7699-5711-5eae-9e2f-1d82baa6b597"

src/MLJBase.jl

@@ -1,6 +1,6 @@
 # Users of this module should first read the document
 # https://alan-turing-institute.github.io/MLJ.jl/dev/adding_models_for_general_use/
-module MLJBase
+module MLJBase 
 
 export MLJType, Model, Supervised, Unsupervised
 export Deterministic, Probabilistic, Interval

src/equality.jl

@@ -14,6 +14,7 @@ Note that Base.== is overloaded such that `m1 == m2` if and only if
 `is_same_except(m1, m2)`.
 
 """
+is_same_except(x1, x2) = ==(x1, x2)
 function is_same_except(m1::M1, m2::M2,
             exceptions::Symbol...) where {M1<:MLJType,M2<:MLJType}
     if typeof(m1) != typeof(m2)
@@ -31,9 +32,9 @@ function is_same_except(m1::M1, m2::M2,
     same_values = true
     for fld in defined1
         same_values = same_values &&
-            (getfield(m1, fld) == getfield(m2, fld) ||
-             getfield(m1, fld) isa AbstractRNG) ||
-             getfield(m2, fld) isa AbstractRNG
+            (is_same_except(getfield(m1, fld), getfield(m2, fld)) ||
+             getfield(m1, fld) isa AbstractRNG ||
+             getfield(m2, fld) isa AbstractRNG)
     end
     return same_values
 end

test/equality.jl

@@ -28,4 +28,20 @@ f1.y = 20
 @test f1 != f2
 @test is_same_except(f1, f2, :x, :y)
 
+# test for nested fields
+
+mutable struct Super <: MLJType
+    sub::Foo
+    z::Int
+end
+
+f1 = Foo(MersenneTwister(7), 1, 2)
+f2 = Foo(MersenneTwister(8), 1, 2)
+s1 = Super(f1, 20)
+s2 = Super(f2, 20)
+@test s1 == s2
+s2.sub.x = 10
+@test f1 != f2
+
+
 true