Fix show for the Node type
#1023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OkonSamuel
reviewed
Oct 21, 2025
OkonSamuel
reviewed
Oct 21, 2025
OkonSamuel
reviewed
Oct 21, 2025
OkonSamuel
reviewed
Oct 21, 2025
OkonSamuel
requested changes
Oct 21, 2025
Member
OkonSamuel
left a comment
OkonSamuel
left a comment
There was a problem hiding this comment.
@ablaom Sorry for the delay in review. I have made some suggestions.
OkonSamuel
approved these changes
Oct 26, 2025
Member
OkonSamuel
left a comment
OkonSamuel
left a comment
There was a problem hiding this comment.
Looks good. I'm happy for this to be merged.
Member
Author
|
Thank you @OkonSamuel for your review 🙏. These reviews are essential in maintaining the quality of the MLJ software. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1022
This PR also adds some show testing and removes some non-public API (
typeof(object).name.name).A line in operations.jl has been removed because it is not used anywhere.