Skip to content

Cleanup - Consistent code style #203

@darrencl

Description

@darrencl

As per the contributing guidelines, we should adhere to blue-style.

However, some parts of the code seems to not following the guideline, e.g.

https://github.com/alan-turing-institute/MLJModels.jl/blob/885bcc0a33a86fe2ee46340f20a9d99c351b1251/src/builtins/Transformers.jl#L252-L253

Which according to bluestyle, this should be

function MLJBase.inverse_transform(
    transformer::UnivariateDiscretizer, result , k::Integer
) 

If the contributors are expected to follow the guidelines, the code will be inconsistent. For that reason, I think we might need to do clean up at some stage to align with the style.

Maybe the easiest is to run JuliaFormatter? With this, the future contributors can easily run the formatter as well. Although, I think at some parts the formatter still doesn't satisfy BlueStyle? (See this issue)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions