Set default user-agent to use package version #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omus
commented
Jun 12, 2025
| using ..AWSExceptions: AWSException | ||
|
|
||
| const user_agent = Ref("AWS.jl/1.0.0") | ||
| const user_agent = Ref{String}("AWS.jl/$(pkgversion(@__MODULE__))") |
Member
Author
There was a problem hiding this comment.
The change to Ref{String} is non-breaking as Ref("") resolves to Ref{String}("")
omus
requested review from
ExpandingMan and
mattBrzezinski
and removed request for
ExpandingMan
mattBrzezinski
approved these changes
Jun 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly set the user-agent to the package version.