Skip to content

Set default user-agent to use package version #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
Merged

Set default user-agent to use package version #724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c617641
Set default user-agent to use package version
omus Jun 12, 2025
a88e3ff
fixup! Set default user-agent to use package version
omus Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ XMLDict = "228000da-037f-5747-90a9-8195ccbf91a5"

[compat]
CodecBase = "0.3"
Compat = "3.32, 4"
Compat = "4.11"
GitHub = "5"
HTTP = "1"
IniFile = "0.5"
Expand Down
4 changes: 2 additions & 2 deletions src/AWS.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module AWS

using Compat: Compat, @compat, @something
using Compat: Compat, @compat, @something, pkgversion
using Base64
using Dates
using Downloads: Downloads, Downloader, Curl
Expand Down Expand Up @@ -44,7 +44,7 @@ include("deprecated.jl")
using ..AWSExceptions
using ..AWSExceptions: AWSException

const user_agent = Ref("AWS.jl/1.0.0")
const user_agent = Ref{String}("AWS.jl/$(pkgversion(@__MODULE__))")
Copy link
Member Author

@omus omus Jun 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to Ref{String} is non-breaking as Ref("") resolves to Ref{String}("")

const aws_config = Ref{AbstractAWSConfig}()

"""
Expand Down
2 changes: 1 addition & 1 deletion test/AWS.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ end
new_user_agent = "new user agent"

try
@test AWS.user_agent[] == "AWS.jl/1.0.0"
@test AWS.user_agent[] == "AWS.jl/$(pkgversion(AWS))"
set_user_agent(new_user_agent)
@test AWS.user_agent[] == new_user_agent
finally
Expand Down
2 changes: 1 addition & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ using AWS.AWSMetadata:
_wraplines,
_validindex
using Base64
using Compat: mergewith
using Compat: mergewith, pkgversion
using Dates
using Downloads
using GitHub
Expand Down
Loading