Merge pull request #30 from JuliaGeometry/sd/fix#28

fix #28

Author: SimonDanisch

.travis.yml

@@ -3,12 +3,8 @@ language: julia
 os:
   - linux
 julia:
-  - 1.3
-  - nightly
-matrix:
-  allow_failures:
-    - julia: nightly
-  fast_finish: true
+  - 1
+if: branch = master OR tag IS present OR type = pull_request
 notifications:
   email: false
 after_success:

src/boundingboxes.jl

@@ -24,22 +24,22 @@ function Rect{N1, T1}(geometry::AbstractArray{PT}) where {N1, T1, PT <: Abstract
 end
 
 function Rect(primitive::GeometryPrimitive{N, T}) where {N, T}
-    Rect{N, T}(primitive)
+    return Rect{N, T}(primitive)
 end
 
 function Rect{T}(primitive::GeometryPrimitive{N, T}) where {N, T}
-    Rect{N, T}(primitive)
+    return Rect{N, T}(primitive)
 end
 
 function Rect{T}(a::Pyramid) where T
     w,h = a.width / T(2), a.length
     m = Vec{3,T}(a.middle)
-    Rect{T}(m .- Vec{3,T}(w,w,0), m .+ Vec{3,T}(w, w, h))
+    return Rect{T}(m .- Vec{3,T}(w,w,0), m .+ Vec{3,T}(w, w, h))
 end
 
 function Rect{T}(a::Sphere) where T
     mini, maxi = extrema(a)
-    Rect{T}(mini, maxi .- mini)
+    return Rect{T}(mini, maxi .- mini)
 end
 
 Rect{T}(a) where T = Rect{T}(coordinates(a))

src/viewtypes.jl

@@ -138,7 +138,13 @@ Tables.schema(faceview::FaceView) = Tables.schema(getfield(faceview, :elements))
 
 Base.size(faceview::FaceView) = size(getfield(faceview, :faces))
 
-Base.show(io::IO, ::Type{<: FaceView{Element}}) where Element = print(io, "FaceView{", Element, "}")
+function Base.show(io::IO, ::Type{<: FaceView{Element}}) where Element
+    if @isdefined Element
+        print(io, "FaceView{", Element, "}")
+    else
+        print(io, "FaceView{T}")
+    end
+end
 
 @propagate_inbounds function Base.getindex(x::FaceView{Element}, i) where Element
     return Element(map(idx-> coordinates(x)[idx], faces(x)[i]))