Skip to content

Commit 417e914

Browse files
authored
Reduce method definitions for cat of AbstractQs (#1500)
1 parent 653ead1 commit 417e914

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

src/abstractq.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,15 +146,13 @@ function copyto!(dest::PermutedDimsArray{T,2,perm}, src::AbstractQ) where {T,per
146146
return dest
147147
end
148148
# used in concatenations: Base.__cat_offset1!
149-
Base._copy_or_fill!(A, inds, Q::AbstractQ) = (A[inds...] = collect(Q))
149+
Base._copy_or_fill!(A, inds, Q::AbstractQ) = copyto!(view(A, inds...), Q)
150150
# overloads of helper functions
151151
Base.cat_size(A::AbstractQ) = size(A)
152152
Base.cat_size(A::AbstractQ, d) = size(A, d)
153153
Base.cat_length(a::AbstractQ) = prod(size(a))
154154
Base.cat_ndims(a::AbstractQ) = ndims(a)
155155
Base.cat_indices(A::AbstractQ, d) = axes(A, d)
156-
Base.cat_similar(A::AbstractQ, T::Type, shape::Tuple) = Array{T}(undef, shape)
157-
Base.cat_similar(A::AbstractQ, T::Type, shape::Vector) = Array{T}(undef, shape...)
158156

159157
function show(io::IO, ::MIME{Symbol("text/plain")}, Q::AbstractQ)
160158
print(io, Base.dims2string(size(Q)), ' ', summary(Q))

0 commit comments

Comments
 (0)