lmul!

Author: jishnub

src/diagonal.jl

@@ -388,7 +388,7 @@ function _rmul!(A::UpperOrLowerTriangular, D::Diagonal)
             P[row, col] *= D.diag[col]
         end
     end
-    isupper && _setdiag!(P, identity, D.diag)
+    isunit && _setdiag!(P, identity, D.diag)
     TriWrapper = isupper ? UpperTriangular : LowerTriangular
     return TriWrapper(P)
 end
@@ -423,10 +423,10 @@ function _lmul!(D::Diagonal, A::UpperOrLowerTriangular)
         rowstart = isupper ? firstindex(A,1) : col+isunit
         rowstop = isupper ? col-isunit : lastindex(A,1)
         for row in rowstart:rowstop
-            P[row, col] = D.diag[col] * P[row, col]
+            P[row, col] = D.diag[row] * P[row, col]
         end
     end
-    isupper && _setdiag!(P, identity, D.diag)
+    isunit && _setdiag!(P, identity, D.diag)
     TriWrapper = isupper ? UpperTriangular : LowerTriangular
     return TriWrapper(P)
 end

test/diagonal.jl

@@ -1197,11 +1197,11 @@ end
     outTri = similar(TriA)
     out = similar(A)
     # 2 args
-    for fun in (*, rmul!, rdiv!, /)
+    @testset for fun in (*, rmul!, rdiv!, /)
         @test fun(copy(TriA), D)::Tri == fun(Matrix(TriA), D)
         @test fun(copy(UTriA), D)::Tri == fun(Matrix(UTriA), D)
     end
-    for fun in (*, lmul!, ldiv!, \)
+    @testset for fun in (*, lmul!, ldiv!, \)
         @test fun(D, copy(TriA))::Tri == fun(D, Matrix(TriA))
         @test fun(D, copy(UTriA))::Tri == fun(D, Matrix(UTriA))
     end