Non-contiguous matrices in triangular mul! and div! #1108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LAPACK functions require contiguous matrices. Currently, the multiplication (BLAS) methods throw errors for non-contiguous arguments, while the
LAPACK.trtrs!
appears to silently accept a non-contiguous argument and returns an incorrect result (JuliaLang/julia#40613). This PR makes such cases fall back to the julia implementation, and only the stride-1 cases are forwarded to the corresponding LAPACK/BLAS functions.Fixes JuliaLang/julia#40613
Fixes #878
After this, in-place multiplication by a triangular matrix works for non-contiguous matrices.