implements a rank(::SVD) method and adds unit tests. fixes #1126
#1127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jishnub
reviewed
Nov 29, 2024
|
This is my first PR so I really appreciate the patience |
stevengj
reviewed
Nov 29, 2024
stevengj
reviewed
Nov 29, 2024
stevengj
reviewed
Nov 29, 2024
|
Honestly I think we can simplify the doc-string by simply saying "computes numerical rank given an SVD decomposition". Does that work? |
stevengj
reviewed
Nov 30, 2024
stevengj
reviewed
Nov 30, 2024
dkarrasch
reviewed
Nov 30, 2024
|
@jishnub do we need a more detailed description for this PR? |
|
I think the description is fine in this case, although perhaps the title shouldn't mention which issue is being fixed. The description already contains this. |
|
On my end I see fixes #1126 in the title. Do you mean a more detailed wording like "implements a rank(::SVD) method" should be in the title? |
ajinkya-k
changed the title
rank(::SVD) method and adds unit tests. fixes #1126
ajinkya-k
changed the title
rank(::SVD) method and adds unit tests. fixes #1126rank(::SVD) method and adds unit tests. fixes #1126
|
Thanks, I think this is fine |
stevengj
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
rank(::SVD)method along with unit tests, and fixes #1126