Skip to content

Conversation

dlfivefifty
Copy link
Contributor

@dlfivefifty dlfivefifty commented Oct 8, 2025

This adds overloads for array conversion for BunchKaufman. This fixes a regression in Julia v1.12-rc3:

julia> a = randn(5,5); A = a'a; F = factorize(A);

julia> typeof(F) # Was a Cholesky in v1.11
BunchKaufman{Float64, Matrix{Float64}, Vector{Int64}}

julia> Array(F) # Succeeded for Cholesky
ERROR: MethodError: no method matching Array(::BunchKaufman{Float64, Matrix{Float64}, Vector{Int64}})
The type `Array` exists, but no method is defined for this combination of argument types when trying to construct it.

Closest candidates are:
  Array(::QL)
   @ MatrixFactorizations ~/Projects/MatrixFactorizations.jl/src/ql.jl:204
  Array(::Eigen)
   @ LinearAlgebra ~/Projects/julia-1.12/usr/share/julia/stdlib/v1.12/LinearAlgebra/src/eigen.jl:682
  Array(::UniformScaling, ::Tuple{Int64, Int64})
   @ LinearAlgebra ~/Projects/julia-1.12/usr/share/julia/stdlib/v1.12/LinearAlgebra/src/uniformscaling.jl:437
  ...

Stacktrace:
 [1] top-level scope
   @ REPL[52]:1

See discussion here: #1461

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.89%. Comparing base (7b21cab) to head (23e122f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1466   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files          34       34           
  Lines       15926    15928    +2     
=======================================
+ Hits        14953    14956    +3     
+ Misses        973      972    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkarrasch dkarrasch added the backport 1.12 Change should be backported to release-1.12 label Oct 9, 2025
@dkarrasch dkarrasch merged commit 28ee87e into JuliaLang:master Oct 12, 2025
4 checks passed
@dkarrasch dkarrasch mentioned this pull request Oct 12, 2025
2 tasks
@dkarrasch dkarrasch removed the backport 1.12 Change should be backported to release-1.12 label Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants