use the same value of --check-bounds as the process (#4494)

Author: KristofferC

CHANGELOG.md

@@ -1,6 +1,8 @@
 Pkg v1.13 Release Notes
 =======================
 
+- `Pkg.test` now respects the `--check-bounds` setting from the parent Julia session instead of forcing `--check-bounds=yes`.
+
 - Project.toml environments now support a `readonly` field to mark environments as read-only, preventing modifications.
   ([#4284])
 - `Pkg.build` now supports an `allow_reresolve` keyword argument to control whether the build process can re-resolve

src/Operations.jl

@@ -2608,7 +2608,6 @@ function gen_subprocess_flags(source_path::String; coverage, julia_args::Cmd)
     return ```
         --code-coverage=$(coverage_arg)
         --color=$(Base.have_color === nothing ? "auto" : Base.have_color ? "yes" : "no")
-        --check-bounds=yes
         --warn-overwrite=yes
         --depwarn=$(Base.JLOptions().depwarn == 2 ? "error" : "yes")
         --inline=$(Bool(Base.JLOptions().can_inline) ? "yes" : "no")

src/Pkg.jl

@@ -390,7 +390,7 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 test = ["Test"]
 ```
 
-The tests are executed in a new process with `check-bounds=yes` and by default `startup-file=no`.
+The tests are executed in a new process with the same `check-bounds` setting as the current Julia session and by default `startup-file=no`.
 If using the startup file (`~/.julia/config/startup.jl`) is desired, start julia with `--startup-file=yes`.
 
 Inlining of functions during testing can be disabled (for better coverage accuracy)