Revert "Make banner size depend on terminal size" #59984
Merged
+81
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
REPL
DilumAluthge
approved these changes
Oct 29, 2025
|
Why are stacktrace tests failing now? |
|
That was broken by yet another PR: #59971 (comment) |
|
#revertathon |
This reverts commit 0f9b2fc.
DilumAluthge
force-pushed
the
revert-51811-banner-to-repl
branch
from
c89e5ee to
7638a58
Compare
|
Tests are now green on |
DilumAluthge
removed
the
merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #51811. This broke tests on x86_64-darwin, ref: #51811 (comment).