doc: workaround for lowering scope mistake #60002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is this related to #59949? Also, any test for this? |
Member
Yes it is - I can confirm it resolves JuliaDiff/ChainRules.jl#826, for example |
Member
|
Looks like we have a simple reproducer then. |
topolarity
added
merge me
topolarity
approved these changes
Oct 31, 2025
mbauman
added
docsystem
KristofferC
pushed a commit
that referenced
this pull request
Nov 5, 2025
Co-authored-by: Cody Tapscott <[email protected]> (cherry picked from commit d5fb6bb)
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc return PR #59882 hits a lowering scope bug #60001 when used with a
x{T} = y{T}type alias declaration. Adding a block avoids that mistake by breaking up the chained assignment optimizations.Resolves #59949.