Skip to content

Commit d4fe98b

Browse files
committed
Do not export the sparse stuff by default
Fix #92
1 parent 5e385e4 commit d4fe98b

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

Project.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,17 @@ uuid = "13e28ba4-7ad8-5781-acae-3021b1ed3924"
33
version = "0.4.5"
44

55
[deps]
6+
DSP = "717857b8-e6f2-59f4-9121-6e50c889abd2"
67
Libdl = "8f399da3-3557-5675-b5ff-fb832c97cbdb"
78
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
89
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
910

1011
[compat]
12+
DSP = "0.8.4"
1113
julia = "1.9"
1214

1315
[extras]
16+
DSP = "717857b8-e6f2-59f4-9121-6e50c889abd2"
1417
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
1518
Distributed = "8ba89e20-285c-5b6f-9357-94700520ee1b"
1619
Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7"
@@ -19,7 +22,6 @@ Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
1922
Sockets = "6462fe0b-24de-5631-8697-dd941f90decc"
2023
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
2124
SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b"
22-
DSP = "717857b8-e6f2-59f4-9121-6e50c889abd2"
2325
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
2426
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
2527

src/AppleAccelerate.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,6 @@ if Sys.isapple()
144144
include("libSparse/wrappers.jl")
145145
include("libSparse/AASparseMatrices.jl")
146146
include("libSparse/AAFactorizations.jl")
147-
export AASparseMatrix, muladd!
148-
export AAFactorization, solve, solve!, factor!
149147
end
150148

151149
end # module

test/libSparseTests.jl

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
using AppleAccelerate
22
using SparseArrays
33
using LinearAlgebra
4+
5+
import AppleAccelerate: AASparseMatrix, muladd!, AAFactorization, solve, solve!, factor!
6+
47
@testset "libSparse" begin
58
@testset "wrappers" begin
69
@testset "SparseMultiply and SparseMultiplyAdd" begin
@@ -252,15 +255,15 @@ using LinearAlgebra
252255
jlA = sprand(Float64, N, M, 0.5)
253256
end
254257
f = AAFactorization(jlA)
255-
258+
256259
# Test solve with wrong dimension vector
257260
wrong_b = rand(Float64, N) # should be M
258261
@test_throws DimensionMismatch solve(f, wrong_b)
259-
262+
260263
# Test solve with wrong dimension matrix
261264
wrong_B = rand(Float64, N, 3) # should be M x 3
262265
@test_throws DimensionMismatch solve(f, wrong_B)
263-
266+
264267
# Test ldiv! with wrong dimensions
265268
x = rand(Float64, N)
266269
b = rand(Float64, M)
@@ -276,7 +279,7 @@ using LinearAlgebra
276279
jlA = sprand(Float64, N, M, 0.9)
277280
end
278281
f = AAFactorization(jlA)
279-
282+
280283
xb_matrix = rand(Float64, M, 3)
281284
@test_throws ArgumentError solve!(f, xb_matrix)
282285
end

0 commit comments

Comments
 (0)