-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed
Description
Problem
pprof_jllnow depends onGraphviz_jllsince add Graphviz as dependency to PProf JuliaPackaging/Yggdrasil#5652.- this is an attempt to address Ship graphviz? #16
- This has some disadvantages
- dependency bloat
- adding packages with licenses some users may not want (e.g. custom libpng license, LGPL license for Cairo)
- It’s a significant number of JLLs that are added.
- graphviz, pango, cairo, etc.
Proposal
Some users don't actually need pprof_jll as a dependency (for example, at RAI). The parts of PProf.jl that we do need, are the parts that convert a profile into the pprof protobuf format. The pprof_jll is there for users to be able to visualize the profiles. We only use PProf for generating protos, as part of https://github.com/JuliaPerf/PerformanceProfilingHttpEndpoints.jl.
What this suggests to me is that probably we should split the PProf package in two (in the same repo):
PProf.jl(Visualization + generating profiles), andPProfProducer, orPProfConverter, orPProfCore, or something like that, which is a package that just provides theprofile => pprof.pb.gzconversion functionality.
Then RAI could depend only on the latter, and thus we wouldn't depend on graphviz_jll.
vilterp
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed