Skip to content

Split package in two, to separate building profile protos from visualizing profiles #72

@NHDaly

Description

@NHDaly

Problem

Proposal

Some users don't actually need pprof_jll as a dependency (for example, at RAI). The parts of PProf.jl that we do need, are the parts that convert a profile into the pprof protobuf format. The pprof_jll is there for users to be able to visualize the profiles. We only use PProf for generating protos, as part of https://github.com/JuliaPerf/PerformanceProfilingHttpEndpoints.jl.

What this suggests to me is that probably we should split the PProf package in two (in the same repo):

  • PProf.jl (Visualization + generating profiles), and
  • PProfProducer, or PProfConverter, or PProfCore, or something like that, which is a package that just provides the profile => pprof.pb.gz conversion functionality.

Then RAI could depend only on the latter, and thus we wouldn't depend on graphviz_jll.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions