Skip to content

Conversation

alyst
Copy link
Contributor

@alyst alyst commented Dec 12, 2024

This PR does 2 things:

  • cleanup savefig(): combine docstring from all 3 versions, streamline keyword argument passing using kwargs...
  • add plotlyjs and plotly_version keyword arguments to savefig() to control which plotly.js Kaleido would be using to generate the figures.
    This is to allow using more recent versions of plotly.js than the one provided by the PlotlyJS.jl (the current one, 2.3.0, is more than a year old).

I have also regenerated the plotly.js artifact using version 2.35.2.
I can provide the file, or the maintainers can run generate_artifacts.jl themselves.

See also comment for PlotlyBase.jl#106

@alyst
Copy link
Contributor Author

alyst commented Dec 12, 2024

Looks like windows tests fail due to kaleido 0.2 issue not related to PR.
Documentation fails because some examples fail to access certain URLs.

@jd-foster
Copy link
Collaborator

Thanks for the PR, I'll try to take a look soon.

@BeastyBlacksmith
Copy link
Member

Would this adress #503 ?

Copy link
Collaborator

@jd-foster jd-foster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice contribution. Sorry for the delay in reviewing.

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.81%. Comparing base (40caf9c) to head (5b3fbf8).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/kaleido.jl 83.33% 3 Missing ⚠️
src/display.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #494       +/-   ##
===========================================
+ Coverage   28.67%   51.81%   +23.13%     
===========================================
  Files           8        8               
  Lines         265      276       +11     
===========================================
+ Hits           76      143       +67     
+ Misses        189      133       -56     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jd-foster jd-foster merged commit 063eb04 into JuliaPlots:master Jul 28, 2025
5 of 7 checks passed
@jd-foster
Copy link
Collaborator

We will fix the documentation failure (not related to this PR) in a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants