Skip to content

Commit 0dc81c5

Browse files
committed
display fix for unlikely but possible type inference failure in bootstrap table
1 parent ec7b986 commit 0dc81c5

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

NEWS.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
MixedModels v5.0.3 Release Notes
2+
==============================
3+
- Small update in some code related to displaying dispersion parameters in cases where inference has failed. [#865]
4+
15
MixedModels v5.0.2 Release Notes
26
==============================
37
- The default display and `confint` methods for bootstrap results from models without dispersion parameters has been fixed. [#861]
@@ -695,3 +699,4 @@ Package dependencies
695699
[#858]: https://github.com/JuliaStats/MixedModels.jl/issues/858
696700
[#860]: https://github.com/JuliaStats/MixedModels.jl/issues/860
697701
[#861]: https://github.com/JuliaStats/MixedModels.jl/issues/861
702+
[#865]: https://github.com/JuliaStats/MixedModels.jl/issues/865

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "MixedModels"
22
uuid = "ff71e718-51f3-5ec2-a782-8ffcbfa3c316"
33
author = ["Phillip Alday <[email protected]>", "Douglas Bates <[email protected]>"]
4-
version = "5.0.2"
4+
version = "5.0.3"
55

66
[deps]
77
Arrow = "69666777-d1a9-59fb-9406-91d4454c9d45"

src/bootstrap.jl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,10 @@ function StatsBase.confint(
359359
par = filter(collect(propertynames(tbl))) do k
360360
k = string(k)
361361
# σ is missing in models without a dispersion parameter
362-
if k == "σ" && Missing <: eltype(tbl.σ)
362+
= eltype(tbl.σ)
363+
# see https://github.com/JuliaStats/MixedModels.jl/pull/861#discussion_r2323094090
364+
# for more info on why this logic is so convulated
365+
if k == "σ" && ((Tσ === Any && any(ismissing, tbl.σ)) || Missing <: Tσ)
363366
return false
364367
end
365368
return !startswith(k, 'θ') && k != "obj"

0 commit comments

Comments
 (0)