Skip to content

Commit 1fca5d9

Browse files
vtjnashlgoettgens
andauthored
remove Base and Core from ambiguities test (#309)
Reporting ambiguities that cannot be fixed by the user since they are not part of the testtarget can be harmful to the user experience since they will never be useful, since at least JuliaLang/julia#36962. --------- Co-authored-by: Lars Göttgens <[email protected]>
1 parent 065f7d7 commit 1fca5d9

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

88

9+
## Version [v0.8.9] - 2024-10-15
10+
11+
### Changed
12+
13+
- Change `test_ambiguities` to only return ambiguities that happen in the target package. ([#309])
14+
15+
916
## Version [v0.8.8] - 2024-10-10
1017

1118
### Changed
@@ -235,6 +242,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
235242
[v0.8.6]: https://github.com/JuliaTesting/Aqua.jl/releases/tag/v0.8.6
236243
[v0.8.7]: https://github.com/JuliaTesting/Aqua.jl/releases/tag/v0.8.7
237244
[v0.8.8]: https://github.com/JuliaTesting/Aqua.jl/releases/tag/v0.8.8
245+
[v0.8.9]: https://github.com/JuliaTesting/Aqua.jl/releases/tag/v0.8.9
238246
[#93]: https://github.com/JuliaTesting/Aqua.jl/issues/93
239247
[#103]: https://github.com/JuliaTesting/Aqua.jl/issues/103
240248
[#113]: https://github.com/JuliaTesting/Aqua.jl/issues/113
@@ -283,3 +291,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
283291
[#287]: https://github.com/JuliaTesting/Aqua.jl/issues/287
284292
[#288]: https://github.com/JuliaTesting/Aqua.jl/issues/288
285293
[#297]: https://github.com/JuliaTesting/Aqua.jl/issues/297
294+
[#309]: https://github.com/JuliaTesting/Aqua.jl/issues/309

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "Aqua"
22
uuid = "4c88cf16-eb10-579e-8560-4a9242c79595"
33
authors = ["Takafumi Arakaki <[email protected]> and contributors"]
4-
version = "0.8.8"
4+
version = "0.8.9"
55

66
[deps]
77
Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"

src/Aqua.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ include("persistent_tasks.jl")
2929
3030
Run the following tests:
3131
32-
* [`test_ambiguities([testtarget, Base, Core])`](@ref test_ambiguities)
32+
* [`test_ambiguities([testtarget])`](@ref test_ambiguities)
3333
* [`test_unbound_args(testtarget)`](@ref test_unbound_args)
3434
* [`test_undefined_exports(testtarget)`](@ref test_undefined_exports)
3535
* [`test_project_extras(testtarget)`](@ref test_project_extras)
@@ -66,7 +66,7 @@ function test_all(
6666
)
6767
@testset "Method ambiguity" begin
6868
if ambiguities !== false
69-
test_ambiguities([testtarget, Base, Core]; askwargs(ambiguities)...)
69+
test_ambiguities([testtarget]; askwargs(ambiguities)...)
7070
end
7171
end
7272
@testset "Unbound type parameters" begin

0 commit comments

Comments
 (0)