Error get_item_for_version(exactVersion: UnityVersion, items: List[Tuple[UnityVersion, Any]])

[Serrallonga25]

Code

def unpack_all_assets(source_folder: str, destination_folder: str):
    # iterate over all files in source folder
    for root, dirs, files in os.walk(source_folder):
        for file_name in files:
            # generate file_path
            file_path = os.path.join(root, file_name)
            # load that file via UnityPy.load
            env = UnityPy.load(file_path)

            # iterate over internal objects
            for obj in env.objects:
                # process specific object types
                if obj.type.name in ["Texture2D", "Sprite"]:
                    # parse the object data
                    data = obj.read()

Error
error('unpack requires a buffer of 1 bytes')

Bug
Does not detect the Unity version structure correctly UnityPy.helpers.Tpk.get_item_for_version(exactVersion: UnityVersion, items: List[Tuple[UnityVersion, Any]]) -> Any:

I pass it the version (2018, 1, 0, 2) and it returns the <UnityPy.helpers.Tpk.TpkUnityClass> of the version (2018, 1, 0, 1)

Original Function:

def get_item_for_version(exactVersion: UnityVersion, items: List[Tuple[UnityVersion, Any]]) -> Any:
    ret = None
    for version, item in items:
        if exactVersion >= version:
            ret = item
        else:
            break
    if ret:
        return ret
    raise ValueError("Could not find exact version")

class_id = 213 #<ClassIDType.Sprite: 213>
version = (2018, 1, 0, 2)

class_info = TPKTYPETREE.ClassInformation[class_id].getVersionedClass(UnityVersion.fromList(*version))

UnityVersion 2018.1.0.2 UnityVersion 2017.3.0.1 568016507297071106 567735040910295297
* UnityVersion 2018.1.0.2 UnityVersion 2018.1.0.2  568016507297071106 568016507297071362

for UnityVersion(2018.1.0.2) it returns UnityVersion(2017.3.0.1) instead of UnityVersion(2018.1.0.2)

and

class_id = 25
version = (2018, 1, 0, 2)
class_info = TPKTYPETREE.ClassInformation[class_id].getVersionedClass(UnityVersion.fromList(*version))

UnityVersion 2018.1.0.2 UnityVersion 2017.3.0.1 568016507297071106 567735040910295297

it's right

Solution:
A possible solution, (it seems to work for me)

def get_item_for_version(exactVersion: UnityVersion, items: List[Tuple[UnityVersion, Any]]) -> Any:
    ret = None
    for version, item in items:
        version = UnityVersion.fromString(str(version).replace('UnityVersion', "").strip())
        if exactVersion >= version:
            ret = item
        else:
            break
    
    if ret:
        return ret
    raise ValueError("Could not find exact version")

I have to do more tests

To Reproduce

• a copy of the file that causes the problem
• following data:
  • Python version 3.9
  • UnityPy version 1.23.0

[K0lb3]

Thanks for reporting the issue.

The root of the issue isn't the comparison logic, but UnityVersion.fromList, how it gets used, and partially the __repr__ which omits the type.

When you compare the UnityVersions as int, you will see the difference.

The current way fromList gets used in UnityPy itself, and probably by many users like you, omits the UnityVersionType (e.g. alpha, beta, ...). Due to this the created version is effectively treated as an alpha version.
In your specific case this is relevant, as the typetree for Sprites changes in the beta version, so after the alpha version.
Therefore >= returns wrong.

[K0lb3]

807f388 should fix the issue