Skip to content

Commit f03fa48

Browse files
committed
Fix User Name with Spaces
1 parent 3527942 commit f03fa48

File tree

7 files changed

+24
-29
lines changed

7 files changed

+24
-29
lines changed

scripts/Linux/Makefile

Lines changed: 14 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,20 @@
11
#!/usr/bin/make -f
22

3-
VERSION=2.0.6
4-
DEBIAN_PACKAGE_VERSION=6
3+
VERSION=2.0.7
4+
DEBIAN_PACKAGE_VERSION=1
55
LAUNCHPAD_NAME=user
66

77
ARCHITECTURE:=$(shell dpkg --print-architecture)
88

9-
.PHONY: allSigned docker-unsigned docker-signed-bionic docker-signed-disco docker-build-image prepare-deb-source unpack-deb-source clean-output-folder copy-debian-folder download-pip build-man build-deb-unsigned build-deb-signed-bionic build-deb-signed-disco ppa deps clean
9+
.PHONY: allSigned docker-unsigned docker-signed_% docker-build-image prepare-deb-source unpack-deb-source clean-output-folder copy-debian-folder download-pip build-man build-deb-unsigned build-deb-signed ppa deps clean
1010

11-
allSigned: clean prepare-deb-source clean-output-folder docker-signed-bionic docker-signed-disco
11+
allSigned: clean prepare-deb-source docker-signed_bionic docker-signed_disco
1212

1313
docker-unsigned: docker-build-image
1414
docker run -ti --rm -v `pwd`/../../:/opt/kathara kathara/linux-build /bin/bash -c "make build-deb-unsigned"
1515

16-
docker-signed-bionic: docker-build-image
17-
docker run -ti --rm -v $(HOME)/.gnupg:/root/.gnupg -v `pwd`/../../:/opt/kathara kathara/linux-build /bin/bash -c "make unpack-deb-source && make build-deb-signed-bionic && make ppa && make clean-output-folder"
18-
19-
docker-signed-disco: docker-build-image
20-
docker run -ti --rm -v $(HOME)/.gnupg:/root/.gnupg -v `pwd`/../../:/opt/kathara kathara/linux-build /bin/bash -c "make unpack-deb-source && make build-deb-signed-disco && make ppa && make clean-output-folder"
16+
docker-signed_%:
17+
docker run -ti --rm -v $(HOME)/.gnupg:/root/.gnupg -v `pwd`/../../:/opt/kathara kathara/linux-build /bin/bash -c "make unpack-deb-source && make build-deb-signed distro=$* && make ppa && make clean-output-folder distro=$*"
2118

2219
docker-build-image:
2320
cd Docker-Linux-Build && docker build -t kathara/linux-build .
@@ -32,11 +29,11 @@ unpack-deb-source:
3229

3330
clean-output-folder:
3431
rm -rf Output/kathara-$(VERSION)
35-
rm -rf Output/kathara_$(VERSION)-$(DEBIAN_PACKAGE_VERSION).debian.tar.xz
36-
rm -rf Output/kathara_$(VERSION)-$(DEBIAN_PACKAGE_VERSION).dsc
37-
rm -rf Output/kathara_$(VERSION)-$(DEBIAN_PACKAGE_VERSION)_source.build
38-
rm -rf Output/kathara_$(VERSION)-$(DEBIAN_PACKAGE_VERSION)_source.buildinfo
39-
rm -rf Output/kathara_$(VERSION)-$(DEBIAN_PACKAGE_VERSION)_source.changes
32+
rm -rf Output/kathara_$(VERSION)-$(DEBIAN_PACKAGE_VERSION)$(distro).debian.tar.xz
33+
rm -rf Output/kathara_$(VERSION)-$(DEBIAN_PACKAGE_VERSION)$(distro).dsc
34+
rm -rf Output/kathara_$(VERSION)-$(DEBIAN_PACKAGE_VERSION)$(distro)_source.build
35+
rm -rf Output/kathara_$(VERSION)-$(DEBIAN_PACKAGE_VERSION)$(distro)_source.buildinfo
36+
rm -rf Output/kathara_$(VERSION)-$(DEBIAN_PACKAGE_VERSION)$(distro)_source.changes
4037

4138
copy-debian-folder:
4239
cp -r debian Output/kathara-$(VERSION)/
@@ -60,12 +57,8 @@ build-deb-unsigned: build-man download-pip
6057
sed -i -e 's/__UBUNTU_VERSION__/bionic/g' Output/kathara-$(VERSION)/debian/changelog
6158
cd Output/kathara-$(VERSION); debuild -us -uc
6259

63-
build-deb-signed-bionic: build-man download-pip
64-
sed -i -e 's/__UBUNTU_VERSION__/bionic/g' Output/kathara-$(VERSION)/debian/changelog
65-
cd Output/kathara-$(VERSION); debuild -S -sa
66-
67-
build-deb-signed-disco: build-man download-pip
68-
sed -i -e 's/__UBUNTU_VERSION__/disco/g' Output/kathara-$(VERSION)/debian/changelog
60+
build-deb-signed: build-man download-pip
61+
sed -i -e 's/__UBUNTU_VERSION__/$(distro)/g' Output/kathara-$(VERSION)/debian/changelog
6962
cd Output/kathara-$(VERSION); debuild -S -sa
7063

7164
ppa:
@@ -77,5 +70,5 @@ deps:
7770

7871
clean:
7972
if [ -d Output ]; then \
80-
rm -r Output; \
73+
rm -rf Output; \
8174
fi

scripts/Linux/debian/changelog

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
kathara (__VERSION__-__DEBIAN_PACKAGE_VERSION____UBUNTU_VERSION__) __UBUNTU_VERSION__; urgency=low
22

3-
* The upload is now done with real source
3+
* Current User Name (used for Docker Container name) is slugified to avoid spaces and special chars.
44

5-
-- Lorenzo Ariemma <l******************a@gmail.com> __DATE__
5+
-- Mariano Scazzariello <***@gmail.com> __DATE__

scripts/OSX/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/usr/bin/make -s
22

33
PRODUCT=Kathara
4-
VERSION=2.0.6
4+
VERSION=2.0.7
55
TARGET_DIRECTORY=Output
66
APPLE_DEVELOPER_CERTIFICATE_ID=FakeID
77
ROFF_DIR=../../docs/Roff

scripts/Windows/installer.iss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
; SEE THE DOCUMENTATION FOR DETAILS ON CREATING INNO SETUP SCRIPT FILES!
33

44
#define MyAppName "Kathara"
5-
#define MyAppVersion "2.0.6"
5+
#define MyAppVersion "2.0.7"
66
#define MyAppPublisher "Kathara Team"
77
#define MyAppURL "http://www.kathara.org"
88
#define MyAppExeName "kathara.exe"

src/Resources/utils.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,15 @@
55
import os
66
import re
77
import shutil
8-
import sys
98
import tarfile
109
import tempfile
1110
from io import BytesIO
1211
from itertools import islice
13-
from sys import platform as _platform
1412

13+
import sys
1514
from binaryornot.check import is_binary
15+
from slugify import slugify
16+
from sys import platform as _platform
1617

1718
from .setting.Setting import EXCLUDED_FILES
1819
from .trdparty.consolemenu import PromptUtils, Screen
@@ -175,7 +176,7 @@ def windows():
175176
import getpass
176177
return getpass.getuser()
177178

178-
return exec_by_platform(unix, windows, unix)
179+
return slugify(exec_by_platform(unix, windows, unix))
179180

180181

181182
def get_current_user_info():

src/Resources/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
CURRENT_VERSION = "2.0.6"
1+
CURRENT_VERSION = "2.0.7"
22

33

44
def parse(version):

src/requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,6 @@ docker>=4.0.2;
33
coloredlogs>=10.0;
44
terminaltables>=3.1.0;
55
requests>=2.22.0;
6+
python-slugify>=4.0.0;
67
appscript>=1.1.0; sys_platform == 'darwin'
78
pypiwin32>=223; sys_platform == 'win32'

0 commit comments

Comments
 (0)