From 319c2ae5b00fd7df06c86d712e2bf0b1e2502dc0 Mon Sep 17 00:00:00 2001 From: Sendan Date: Wed, 3 Sep 2025 10:37:39 -0400 Subject: [PATCH 1/2] Fixing glslang bin build with MinGW. Setting the macro GLSLANG_EXPORTING by going public with GLSLANG_IS_SHARED_LIBRARY --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index f26987d4e8..4b7c9215fa 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -259,7 +259,7 @@ function(glslang_only_export_explicit_symbols target) set_target_properties(${target} PROPERTIES CXX_VISIBILITY_PRESET hidden) set_target_properties(${target} PROPERTIES C_VISIBILITY_PRESET hidden) if(WIN32) - target_compile_definitions(${target} PRIVATE "GLSLANG_EXPORTING=1") + target_compile_definitions(${target} PUBLIC "GLSLANG_EXPORTING=1") endif() endif() endfunction() From 522e01964ae4a75a00f0c9ce07e0554dfb93bd52 Mon Sep 17 00:00:00 2001 From: Sendan Date: Wed, 3 Sep 2025 13:53:49 -0400 Subject: [PATCH 2/2] Fix CI errors and make the change case especific --- CMakeLists.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 4b7c9215fa..be1dd637db 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -259,7 +259,11 @@ function(glslang_only_export_explicit_symbols target) set_target_properties(${target} PROPERTIES CXX_VISIBILITY_PRESET hidden) set_target_properties(${target} PROPERTIES C_VISIBILITY_PRESET hidden) if(WIN32) - target_compile_definitions(${target} PUBLIC "GLSLANG_EXPORTING=1") + if(${CMAKE_CXX_COMPILER_ID} MATCHES "GNU") + target_compile_definitions(${target} PUBLIC "GLSLANG_EXPORTING=1") + else() + target_compile_definitions(${target} PRIVATE "GLSLANG_EXPORTING=1") + endif() endif() endif() endfunction()