Skip to content

Commit 403af70

Browse files
authored
Merge branch 'master' into dev
2 parents bef0208 + 6f34574 commit 403af70

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

easydata.js/packs/core/tests/aggr_settings.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ describe('AggregationSettings', () => {
1010
let settings: AggregationSettings;
1111

1212
beforeEach(() => {
13-
// Create mock for AggregationColumnStore
13+
// Creating a mock for AggregationColumnStore
1414
columnStore = mock<AggregationColumnStore>({
1515
getColumnIds: (from, to) => {
1616
const result = [];
@@ -126,7 +126,7 @@ describe('AggregationSettings', () => {
126126
});
127127

128128
it('should check if settings are valid', () => {
129-
// No groups and aggregates -> invalid
129+
// Non-existent groups and aggregates -> invalid
130130
expect(settings.isValid()).toBe(false);
131131

132132
// Only groups -> invalid
@@ -137,7 +137,7 @@ describe('AggregationSettings', () => {
137137
settings.addAggregateColumn('col2', 'sum');
138138
expect(settings.isValid()).toBe(true);
139139

140-
// Only aggregates and total -> valid
140+
// Only aggregates and totals -> valid
141141
settings.clear();
142142
settings.addAggregateColumn('col1', 'sum');
143143
settings.addGrandTotals();

0 commit comments

Comments
 (0)