Flow still alive after one-sided connection close by client

[slainless]

Describe the bug
So the flow the server is collecting is still alive even after client disconnect.
Is this by design? Does that mean I have to add timeout to every flow consumer in case the client hangs up?

To Reproduce
Steps to reproduce the behavior:

1. Kotlin version: 2.2.0
2. Gradle version: 8.9
3. OS (Or at least KMP platform): JVM
4. KRPC: 0.9.1

Expected behavior
Shouldn't the flow throw with cancellation when client disconnect?

Additional context
I'm using flow to stream ByteArray to remote server.

I don't know if this is relevant but I'm using ktor client + okhttp and ktor server + netty, and waitForServices: true

EDIT:
Perhaps related to #446?

[Mr3zee]

Hey! Yes, it is probably #446

[Mr3zee]

@slainless please check with Ktor 3.3.0

[Mr3zee]

Oh, hm, maybe actually it is a bug and I know where, I'll check that too

[slainless]

You’re right, I’m not on the latest Ktor

I will try and get back to you soon

[Mr3zee]

If the issue is not resolved - please provide a reproducer
I checked my theory and tests - and it should work properly

[slainless]

Sorry for the long wait, here is the minimum repro in KMP

• Client emit first data
• Server received the first data
• Client immediately close
• Server session stuck waiting for flow (second read) that is already closed
• But, the server correctly throw connection close when trying to emit to the closed connection. Try swapping the order between read and emit on the server

https://github.com/slainless/repro-krpc-flow

[Mr3zee]

@slainless please note that on server you still use Ktor 3.2.3:

implementation(libs.ktor.serverCore)
implementation(libs.ktor.serverNetty)

Please try with 3.3.0 and tell me if the problem stays - I'll take a look then. And thank you for the reproducer!

[slainless]

Oops, sorry, the catalog was not commited.

Please check again. Last night was tested with 3.3.0 and just tested it again.
I'm pretty sure its either this is reproduceable in latest ktor or my gradle somehow use older version.

[Mr3zee]

Np, I'll take a closer look than