-
Notifications
You must be signed in to change notification settings - Fork 13
Description
As shown on the Status page, the spec has been updated. Some things have been added, and some things have changed.
Changed
- type of
echoCancellationonMediaTrackCapabilitiestosequence<(boolean or DOMString)>fromsequence<boolean>.⚠️ - type of
echoCancellationonMediaTrackConstraintSettoConstrainBooleanOrDOMStringfromConstrainBoolean.⚠️ - type of
echoCancellationonMediaTrackSettingsto(boolean or DOMString)fromboolean.⚠️ - the event type of
devicechangetoDeviceChangeEventfromEvent.
Some of these changes (marked with EchoCancellationModeEnum values in its MediaTrackCapabilities, which I have observed recently. So I would like to update it soon. I might even make a major release with these changes alone, before the added features are done, to stabilize it again. Another option is to temporarily make a fix for it by adding a custom converter for a bool[]? that would ignore types that were not a bool.
Added
boolean backgroundBlurtoMediaTrackSupportedConstraints.sequence<boolean> backgroundBlurtoMediaTrackCapabilities.ConstrainBoolean backgroundBlurtoMediaTrackConstraintSet.boolean backgroundBlurtoMediaTrackSettings.EchoCancellationModeEnumtype.DeviceChangeEventtype.DeviceChangeEventInittype.getUserMediaonNavigator, which is ourMediaDevicesService.ConstrainBooleanOrDOMStringParameterswhich has properties that should be a union of aboolandEchoCancellationModeEnum.ConstrainBooleanOrDOMStringwhich should be represented by a union type ofbool,EchoCancellationMode, andConstrainBooleanOrDOMStringParameters.
All of these can be added without issue.
Could I have caught it earlier?
Yes. First, I could have added more tests, but having them alone would not have helped if I did not run them periodically. I'm considering creating a job or similar process to run my tests periodically and alert me if they suddenly fail to parse. That could be expanded further in a subsequent issue.