Skip to content

Calls to Kokkos::min and Kokkos:max are incorrect if ENABLE_KOKKOS=On #323

@dogunter

Description

@dogunter

I've been trying to build RAJAPerf with the cmake option ENABLE_KOKKOS=On but it fails with two error messages,

"/home/dog/kokkos/testing/RAJAPerf/src/basic-kokkos/REDUCE3_INT-Kokkos.cpp", line 58: error: namespace "Kokkos" has no member "min"
        m_vmin = Kokkos::min(m_vmin, static_cast<Int_type>(min_value));
                         ^

"/home/dog/kokkos/testing/RAJAPerf/src/basic-kokkos/REDUCE3_INT-Kokkos.cpp", line 59: error: namespace "Kokkos" has no member "max"
        m_vmax = Kokkos::max(m_vmax, static_cast<Int_type>(max_value));
                         ^

Steps to reproduce:

$ module load cmake
$ module load nvhpc/23.1
$ git clone --recursive https://github.com/LLNL/RAJAPerf.git
$ cd RAJAPerf
$ mkdir build; cd build
$ cmake   -DENABLE_KOKKOS=On ..
$ make -j

It appears to be a simple case issue. The correct call should be to Kokkos::Min and Kokkos:Max, respectively.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions