Non-blocking read option on socket #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds test: test_run for WebSocket.py
auvipy
requested changes
Sep 17, 2024
Collaborator
auvipy
left a comment
auvipy
left a comment
There was a problem hiding this comment.
can you please rebase it?
auvipy
requested changes
Sep 18, 2024
Signed-off-by: Asif Saif Uddin <[email protected]>
auvipy
requested changes
Dec 24, 2024
Signed-off-by: Asif Saif Uddin <[email protected]>
auvipy
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created WebSocket.sock_timeout property to be able to use
sock.settimeout(self.sock_timeout)for non-blocking reads when a timeout value is provided. When the default value of None is used, the blocking behavior is unchanged.