Add an option to clean the package after install (#39)

Author: LinuxSuRen

cmd/install.go

@@ -33,6 +33,8 @@ func NewInstallCmd() (cmd *cobra.Command) {
 		"If fetch the latest config from https://github.com/LinuxSuRen/hd-home")
 	flags.BoolVarP(&opt.Download, "download", "", true,
 		"If download the package")
+	flags.BoolVarP(&opt.CleanPackage, "clean-package", "", true,
+		"Clean the package if the installation is success")
 	flags.IntVarP(&opt.Thread, "thread", "t", 4,
 		`Download file with multi-threads. It only works when its value is bigger than 1`)
 	flags.BoolVarP(&opt.KeepPart, "keep-part", "", false,
@@ -45,8 +47,9 @@ func NewInstallCmd() (cmd *cobra.Command) {
 
 type installOption struct {
 	downloadOption
-	Download bool
-	Mode     string
+	Download     bool
+	CleanPackage bool
+	Mode         string
 }
 
 func (o *installOption) preRunE(cmd *cobra.Command, args []string) (err error) {
@@ -69,12 +72,13 @@ func (o *installOption) runE(cmd *cobra.Command, args []string) (err error) {
 
 	var source string
 	var target string
+	tarFile := o.Output
 	if o.Tar {
-		if err = o.extractFiles(o.Output, o.name); err == nil {
-			source = fmt.Sprintf("%s/%s", filepath.Dir(o.Output), o.name)
+		if err = o.extractFiles(tarFile, o.name); err == nil {
+			source = fmt.Sprintf("%s/%s", filepath.Dir(tarFile), o.name)
 			target = fmt.Sprintf("/usr/local/bin/%s", targetBinary)
 		} else {
-			err = fmt.Errorf("cannot extract %s from tar file, error: %v", o.Output, err)
+			err = fmt.Errorf("cannot extract %s from tar file, error: %v", tarFile, err)
 		}
 	} else {
 		source = o.downloadOption.Output
@@ -101,6 +105,12 @@ func (o *installOption) runE(cmd *cobra.Command, args []string) (err error) {
 		if err == nil && o.Package != nil && o.Package.TestInstall != nil {
 			err = execCommand(o.Package.TestInstall.Cmd, o.Package.TestInstall.Args...)
 		}
+
+		if err == nil && o.CleanPackage {
+			if cleanErr := os.RemoveAll(tarFile); cleanErr != nil {
+				cmd.Println("cannot remove file", tarFile, ", error:", cleanErr)
+			}
+		}
 	}
 	return
 }
@@ -118,15 +128,19 @@ func (o *installOption) overWriteBinary(sourceFile, targetPath string) (err erro
 		}
 
 		var cp string
-		if cp, err = exec.LookPath("cp"); err == nil {
-			err = syscall.Exec(cp, []string{"cp", sourceFile, targetPath}, os.Environ())
+		if cp, err = exec.LookPath("mv"); err == nil {
+			err = syscall.Exec(cp, []string{"mv", sourceFile, targetPath}, os.Environ())
 		}
 	default:
 		sourceF, _ := os.Open(sourceFile)
 		targetF, _ := os.OpenFile(targetPath, os.O_CREATE|os.O_RDWR, 0600)
 		if _, err = io.Copy(targetF, sourceF); err != nil {
 			err = fmt.Errorf("cannot copy %s from %s to %v, error: %v", o.name, sourceFile, targetPath, err)
 		}
+
+		if err == nil {
+			_ = os.RemoveAll(sourceFile)
+		}
 	}
 	return
 }