Fix being unable to rename users (#885)

Author: jvyden

Refresh.Database/GameDatabaseContext.Notifications.cs

@@ -16,15 +16,13 @@ public void AddNotification(string title, string text, GameUser user, string? ic
         {
             Title = title,
             Text = text,
-            User = user,
+            UserId = user.UserId,
             FontAwesomeIcon = icon,
             CreatedAt = this._time.Now,
         };
-
-        this.Write(() =>
-        {
-            this.GameNotifications.Add(notification);
-        });
+        
+        this.GameNotifications.Add(notification);
+        this.SaveChanges();
     }
 
     public void AddErrorNotification(string title, string text, GameUser user)

Refresh.Database/GameDatabaseContext.Users.cs

@@ -279,11 +279,9 @@ public DatabaseList<GameUser> GetAllUsersWithRole(GameUserRole role)
     public void RenameUser(GameUser user, string newUsername)
     {
         string oldUsername = user.Username;
-        
-        this.Write(() =>
-        {
-            user.Username = newUsername;
-        });
+
+        user.Username = newUsername;
+        this.SaveChanges();
 
         this.AddNotification("Username Updated", $"An admin has updated your account's username from '{oldUsername}' to '{newUsername}'. " +
                                                  $"If there are any problems caused by this, please let us know.", user);

Refresh.Database/Models/Notifications/GameNotification.cs

@@ -14,8 +14,10 @@ public partial class GameNotification
     public string Text { get; set; }
 
     public DateTimeOffset CreatedAt { get; set; }
-    [Required]
+    [ForeignKey(nameof(UserId)), Required]
     public GameUser User { get; set; }
+    [Required]
+    public ObjectId UserId { get; set; }
 
     public string FontAwesomeIcon { get; set; }
 }