Skip to content

Commit 4ab8d49

Browse files
Added support for Internet Explorer
1 parent c81efdc commit 4ab8d49

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

.vscode/settings.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
},
1212
"files.exclude": {
1313
"dist/": true,
14-
".github/": false,
14+
"index.js": true,
1515
"**/.DS_Store": true,
1616
"**/.directory": true,
1717
"**/desktop.ini": true,

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,9 @@ npm publish # Publish package to NPM
6060
6161
## Create and publish Tag
6262
63-
Remember to commit first
64-
6563
```shell
66-
git tag -a -m "Published v1.1.2" v1.1.2 # Tag your release
64+
gac New commit # Git add and commit + message
65+
git tag -a -m "Published v1.1.3" v1.1.3 # Tag your release
6766
git push --follow-tags # Push commit and tags
6867
```
6968

index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ module.exports = (columns, content, settings:ISettings = {}, download:boolean =
3434
let xx = excelIndexes[whileLoop]
3535
let size = { width: newSheet[xx].v.length + extraLength } // Default width is the header width
3636
for (let keyIndex in newSheet) { // Setting each col width based on max width element
37-
if (newSheet.hasOwnProperty(keyIndex) && keyIndex.startsWith(xx.slice(0, -1)) && keyIndex.length === xx.length) {
37+
if (newSheet.hasOwnProperty(keyIndex) && (xx.charAt(0) === keyIndex.charAt(0)) && keyIndex.length === xx.length) {
3838
let consideredElement = newSheet[keyIndex].v
3939
if (typeof consideredElement === 'number') consideredElement = '' + consideredElement
4040
if (consideredElement && consideredElement.length >= size.width) size.width = consideredElement.length + extraLength

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "json-as-xlsx",
3-
"version": "1.1.2",
3+
"version": "1.1.3",
44
"license": "MIT",
55
"main": "index.js",
66
"files": [

src/App.vue

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
<h1>Testing json-as-xlsx</h1>
44
<button @click="downloadFile">Download</button>
55
<h2>
6+
<span>See this project on: </span>
67
<a href="https://github.com/LuisEnMarroquin/json-as-xlsx">GitHub</a>
78
</h2>
89
</div>
@@ -13,11 +14,11 @@ const xlsx = require('../index.js')
1314
export default {
1415
name: 'App',
1516
methods: {
16-
downloadFile: (event) => {
17+
downloadFile: function (event) {
1718
var columns = [
1819
{ label: 'Email', value: 'email' },
19-
{ label: 'Age', value: row => (row.age + ' years') },
20-
{ label: 'Password', value: row => (row.hidden ? row.hidden.password : '') }
20+
{ label: 'Age', value: function x(row) { return (row.age + ' years') } },
21+
{ label: 'Password', value: function x(row) { return (row.hidden ? row.hidden.password : '') } }
2122
]
2223
var content = [
2324
{ email: 'Ana', age: 16, hidden: { password: '11111111' } },

0 commit comments

Comments
 (0)