fix: fixed edge cases leading to failures in ci

There were a few things here. For starters some of the new tests had some dumb config. A mistake on my part.

The other part is that the `send` throws different errors depending on platform and context. I could only reasonably track it down based on testing in the CI... There are 3 main errors we're sending back to the connection to be dealt with.

Author: tegefaulkes

src/QUICClient.ts

@@ -258,12 +258,25 @@ class QUICClient {
       evt: events.EventQUICClientErrorSend,
     ) => {
       // @ts-ignore: the error contains `code` but not part of the type
-      if (evt.detail.code === 'EINVAL') {
-        abortController.abort(
-          new errors.ErrorQUICClientInvalidArgument(undefined, {
-            cause: evt.detail,
-          }),
-        );
+      const code = evt.detail.code;
+      switch (code) {
+        // Thrown due to invalid arguments on linux
+        case 'EINVAL':
+        // Thrown due to invalid arguments on macOS
+        // Falls through
+        case 'EADDRNOTAVAIL':
+        // Thrown due to invalid arguments on Win but also for network dropouts on all platforms
+        // Falls through
+        case 'ENETUNREACH':
+          {
+            abortController.abort(
+              new errors.ErrorQUICClientInvalidArgument(undefined, {
+                cause: evt.detail,
+              }),
+            );
+          }
+          break;
+        default: // Do nothing
       }
     };
     client.addEventListener(
@@ -331,10 +344,6 @@ class QUICClient {
   protected config: Config;
   protected _closed: boolean = false;
   protected resolveClosedP: () => void;
-  /**
-   * Flag used to make sure network fail warnings are only logged once per failure
-   */
-  protected networkWarned: boolean = false;
 
   /**
    * Handles `EventQUICClientError`.
@@ -494,10 +503,16 @@ class QUICClient {
         evt.detail.port,
         evt.detail.address,
       );
-      this.networkWarned = false;
     } catch (e) {
       switch (e.code) {
+        // Thrown due to invalid arguments on linux
         case 'EINVAL':
+        // Thrown due to invalid arguments on macOS
+        // Falls through
+        case 'EADDRNOTAVAIL':
+        // Thrown due to invalid arguments on Win but also for network dropouts on all platforms
+        // Falls through
+        case 'ENETUNREACH':
           {
             this.dispatchEvent(
               new events.EventQUICClientErrorSend(
@@ -509,18 +524,6 @@ class QUICClient {
             );
           }
           break;
-        case 'ENETUNREACH':
-          {
-            // We consider this branch a temp failure.
-            // For these error codes we rely on the connection's timeout to handle.
-            if (!this.networkWarned) {
-              this.logger.warn(
-                `client send failed with 'ENETUNREACH', likely due to network failure`,
-              );
-              this.networkWarned = true;
-            }
-          }
-          break;
         default:
           {
             this.dispatchEvent(

src/QUICServer.ts

@@ -62,10 +62,6 @@ class QUICServer {
   protected _closed: boolean = false;
   protected _closedP: Promise<void>;
   protected resolveClosedP: () => void;
-  /**
-   * Flag used to make sure network fail warnings are only logged once per failure
-   */
-  protected networkWarned: boolean = false;
 
   /**
    * Handles `EventQUICServerError`.
@@ -199,10 +195,16 @@ class QUICServer {
         evt.detail.port,
         evt.detail.address,
       );
-      this.networkWarned = false;
     } catch (e) {
       switch (e.code) {
+        // Thrown due to invalid arguments on linux
         case 'EINVAL':
+        // Thrown due to invalid arguments on macOS
+        // Falls through
+        case 'EADDRNOTAVAIL':
+        // Thrown due to invalid arguments on Win but also for network dropouts on all platforms
+        // Falls through
+        case 'ENETUNREACH':
           {
             this.dispatchEvent(
               new events.EventQUICClientErrorSend(
@@ -214,18 +216,6 @@ class QUICServer {
             );
           }
           break;
-        case 'ENETUNREACH':
-          {
-            // We consider this branch a temp failure.
-            // For these error codes we rely on the connection's timeout to handle.
-            if (!this.networkWarned) {
-              this.logger.warn(
-                `server send failed with 'ENETUNREACH', likely due to network failure`,
-              );
-              this.networkWarned = true;
-            }
-          }
-          break;
         default:
           {
             this.dispatchEvent(

tests/QUICStream.test.ts

@@ -1893,7 +1893,7 @@ describe(QUICStream.name, () => {
     const client = await QUICClient.createQUICClient({
       host: localhost,
       port: server.port,
-      localHost: '192.168.56.1',
+      localHost: localhost,
       crypto: {
         ops: clientCrypto,
       },
@@ -2025,7 +2025,7 @@ describe(QUICStream.name, () => {
     const client = await QUICClient.createQUICClient({
       host: localhost,
       port: server.port,
-      localHost: '192.168.56.1',
+      localHost: localhost,
       crypto: {
         ops: clientCrypto,
       },