Hardening: Make mbedtls_ssl_get_verify_result() default to failure
#10442
+35
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At initialization, set the verify_result field of the ssl session to 0xFFFFFFFF, indicating failure of the handshake. This prevents mbedtls_ssl_get_verify_result() from indicating that certificate verification has passed if it is called prior to the handshake happening. Signed-off-by: David Horstmann <[email protected]>
Write a testcase to get verify_result before we have performed a handshake and make sure that it is initialised to a failure value. Signed-off-by: David Horstmann <[email protected]>
Signed-off-by: David Horstmann <[email protected]>
5 tasks
davidhorstmann-arm
added
needs-review
davidhorstmann-arm
moved this from In Development
to In Review
in Non-roadmap pull requests
Contributor
This solution could have been cleaner. There are unused bits in 32-bit integer, it would be more appropriate to take one bit and give it a good name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard against a potential API misuse. Currently, when
mbedtls_ssl_get_verify_result()is called before attempting a handshake, it returns 0 indicating success.Change this so that we initialize the result to 0xFFFFFFFF (indicating failure) when we first initialize the session object.
Fixes #10373
PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.
mbedtls_ssl_get_verify_result()default to failure #10443