Request to add additional values to asserition/aattestation

[squinn7]

Hello,

First off, this project is great and I was able to learn a lot about working with windows api's that I hadn't done before.

I recently did a proof of concept for mobile app to add passkey support and was able to lean on this library to add windows support.

However, I did my integration with Amazon Cognito and it requires a few more values from both the assertion and attestation than are currently provided public api. I have a branch with these changes and was interested to know if you would be interested in merging them into the main project.

Summary of changes below:

Updated Assertion:

Updated Attestation:

[MichaelGrafnetter]

@squinn7 Makes sense. Is there any public documentation of Amazon's Passkey API?

[squinn7]

Their documentation is a little frustrating as they don't have an example and their guidance is simply to match the w3c specification for the json payload but they don't even require the exact same fields as the spec.

https://docs.aws.amazon.com/cognito/latest/developerguide/amazon-cognito-user-pools-authentication-flow-methods.html?icmpid=docs_cognito_console_help_panel#amazon-cognito-user-pools-authentication-flow-methods-passkey

I will caution that for assertion, it is a breaking change as cognito requires the user id be returned in the response and the structure of that json is different than what was currently returned by AuthenticatorGetAssertion. I had to introduce a new object for that method to return.

I have the PR ready to go. I tried to follow along with the rest of the but if any changes are needed I can do that.

[squinn7]

To summarize, I needed the credential id from the assertion and the AuthenticatorData and Transports for the Attestation

[MichaelGrafnetter]

Thx. I will need to get familiar with the docs and test it. Please be patient.