Persistent command: Merge the two keypresses to one

[egmontkob]

Is there an existing issue for this?

• I have searched the existing issues

Midnight Commander version and build configuration

current git

Operating system

all

Is this issue reproducible using the latest version of Midnight Commander?

• I confirm the issue is still reproducible with the latest version of Midnight Commander

How to reproduce

Persistent command line feature registers two keypresses \e_ and \e+. They report 2 or 3 pieces of information (command line, cursor position, bash version to tell whether the position is in bytes or characters). There's nothing we could do with just one piece of this information.

I find especially ugly that we send 3 pieces of information in 2 steps.

I think the code (especially the init string we inject to shells) would become a bit cleaner if we joined these to a single keypress. It would respond with cursor position (and bash version), newline, command line. mc could easily split at the first newline (as it already splits at whatever separator for the bash version).

Extracting a separate method read_command_buffer_with_timeout() (pending in #4625) would become pointless.

We'd pollute the shortcut keys space less.

(Quite low prio and negligible impact issue, but I'm happy to do this if noone objects.)

Expected behavior

.

Actual behavior

.

Additional context

No response

[zyv]

To me, this sounds like a desirable improvement... I don't think that there was great design behind splitting it, but rather I think it happened historically, and then nobody gave it a second thought so far and decided to refactor the code.