Add support for viewing and edit xcmappingmodel files #3242
+47
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasromanomr
force-pushed
the
fix/show-xcmappingmodel
branch
from
01a666e to
5be405c
Compare
adincebic
approved these changes
Nov 4, 2025
Contributor
adincebic
left a comment
adincebic
left a comment
There was a problem hiding this comment.
This is great, thanks @lucasromanomr
lucasromanomr
changed the title
lucasromanomr
changed the title
lucasromanomr
changed the title
lucasromanomr
changed the title
lucasromanomr
force-pushed
the
fix/show-xcmappingmodel
branch
from
5be405c to
0e8968d
Compare
brentleyjones
approved these changes
Nov 7, 2025
Contributor
brentleyjones
left a comment
brentleyjones
left a comment
There was a problem hiding this comment.
Please also update CHANGELOG.md.
lucasromanomr
force-pushed
the
fix/show-xcmappingmodel
branch
from
0e8968d to
a580f80
Compare
Contributor
|
You'll need to sign off on the git commit to pass the DCO check. Please mention me once you do and I can approve the PR for CI. |
Contributor
Author
I did the push and I was waiting for the checks, they called me and I ended up leaving it to see later to see if everything was ok, I came back now to see and I saw. Doing it now 😅 |
Signed-off-by: Lucas Romano <[email protected]>
Signed-off-by: Lucas Romano <[email protected]>
lucasromanomr
force-pushed
the
fix/show-xcmappingmodel
branch
from
a580f80 to
dcda917
Compare
adincebic
approved these changes
Nov 12, 2025
brentleyjones
merged commit cd450a8
into
MobileNativeFoundation:main
9 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the handling of
.xcmappingmodelfiles in the file and group element creation logic, ensuring they are treated correctly as file references rather than groups. It also adds a dedicated unit test to verify this behavior.Before implementation, only the .xml file was visible, inside a regular folder. In addition to only being able to view the XML content and not the Xcode preview,
Now there is interpretation via Xcode.
In addition to displaying correctly in the file structure, when opened, it shows the Xcode preview and not just the XML as before.