Skip to content

Commit 7d16986

Browse files
committed
Replace glog with klog/v2 package
Signed-off-by: Janusz Marcinkiewicz <[email protected]>
1 parent 178bc80 commit 7d16986

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+4753
-2021
lines changed

go.mod

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,15 @@ go 1.18
55
require (
66
github.com/NVIDIA/gpu-monitoring-tools v0.0.0-20211102125545-5a2c58442e48
77
github.com/fsnotify/fsnotify v1.4.9
8-
github.com/golang/glog v1.1.0
98
github.com/onsi/ginkgo v1.11.0
109
github.com/onsi/gomega v1.7.0
1110
google.golang.org/grpc v1.56.2
11+
k8s.io/klog/v2 v2.100.1
1212
k8s.io/kubelet v0.19.16
1313
)
1414

1515
require (
16+
github.com/go-logr/logr v1.2.4 // indirect
1617
github.com/gogo/protobuf v1.3.2 // indirect
1718
github.com/golang/protobuf v1.5.3 // indirect
1819
github.com/hpcloud/tail v1.0.0 // indirect

go.sum

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,9 @@ github.com/go-logfmt/logfmt v0.3.0/go.mod h1:Qt1PoO58o5twSAckw1HlFXLmHsOX5/0LbT9
6767
github.com/go-logfmt/logfmt v0.4.0/go.mod h1:3RMwSq7FuexP4Kalkev3ejPJsZTpXXBr9+V4qmtdjCk=
6868
github.com/go-logr/logr v0.1.0/go.mod h1:ixOQHD9gLJUVQQ2ZOR7zLEifBX6tGkNJF4QyIY7sIas=
6969
github.com/go-logr/logr v0.2.0/go.mod h1:z6/tIYblkpsD+a4lm/fGIIU9mZ+XfAiaFtq7xTgseGU=
70+
github.com/go-logr/logr v1.2.0/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=
71+
github.com/go-logr/logr v1.2.4 h1:g01GSCwiDw2xSZfjJ2/T9M+S6pFdcNtFYsp+Y43HYDQ=
72+
github.com/go-logr/logr v1.2.4/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=
7073
github.com/go-openapi/jsonpointer v0.0.0-20160704185906-46af16f9f7b1/go.mod h1:+35s3my2LFTysnkMfxsJBAMHj/DoqoB9knIWoYG/Vk0=
7174
github.com/go-openapi/jsonreference v0.0.0-20160704190145-13c6e3589ad9/go.mod h1:W3Z9FmVs9qj+KR4zFKmDPGiLdk1D9Rlm7cyMvf57TTg=
7275
github.com/go-openapi/spec v0.0.0-20160808142527-6aced65f8501/go.mod h1:J8+jY1nAiCcj+friV/PDoE1/3eeccG9LYBs0tYvLOWc=
@@ -75,8 +78,6 @@ github.com/go-stack/stack v1.8.0/go.mod h1:v0f6uXyyMGvRgIKkXu+yp6POWl0qKG85gN/me
7578
github.com/gogo/protobuf v1.3.2 h1:Ov1cvc58UF3b5XjBnZv7+opcTcQFZebYjWzi34vdm4Q=
7679
github.com/gogo/protobuf v1.3.2/go.mod h1:P1XiOD3dCwIKUDQYPy72D8LYyHL2YPYrpS2s69NZV8Q=
7780
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b/go.mod h1:SBH7ygxi8pfUlaOkMMuAQtPIUF8ecWP5IEl/CR7VP2Q=
78-
github.com/golang/glog v1.1.0 h1:/d3pCKDPWNnvIWe0vVUpNP32qc8U3PDVxySP/y360qE=
79-
github.com/golang/glog v1.1.0/go.mod h1:pfYeQZ3JWZoXTV5sFc986z3HTpwQs9At6P4ImfuP3NQ=
8081
github.com/golang/groupcache v0.0.0-20190702054246-869f871628b6/go.mod h1:cIg4eruTrX1D+g88fzRXU5OdNfaM+9IcxsU14FzY7Hc=
8182
github.com/golang/groupcache v0.0.0-20191227052852-215e87163ea7/go.mod h1:cIg4eruTrX1D+g88fzRXU5OdNfaM+9IcxsU14FzY7Hc=
8283
github.com/golang/mock v1.1.1/go.mod h1:oTYuIxOrZwtPieC+H1uAHpcLFnEyAGVDL/k47Jfbm0A=
@@ -368,6 +369,8 @@ k8s.io/component-base v0.19.16/go.mod h1:XHLw2qCaaY0B2IAN4ec+pi4AS5KxlfugYol7dy7
368369
k8s.io/gengo v0.0.0-20200413195148-3a45101e95ac/go.mod h1:ezvh/TsK7cY6rbqRK0oQQ8IAqLxYwwyPxAX1Pzy0ii0=
369370
k8s.io/klog/v2 v2.0.0/go.mod h1:PBfzABfn139FHAV07az/IF9Wp1bkk3vpT2XSJ76fSDE=
370371
k8s.io/klog/v2 v2.2.0/go.mod h1:Od+F08eJP+W3HUb4pSrPpgp9DGU4GzlpG/TmITuYh/Y=
372+
k8s.io/klog/v2 v2.100.1 h1:7WCHKK6K8fNhTqfBhISHQ97KrnJNFZMcQvKp7gP/tmg=
373+
k8s.io/klog/v2 v2.100.1/go.mod h1:y1WjHnz7Dj687irZUWR/WLkLc5N1YHtjLdmgWjndZn0=
371374
k8s.io/kube-openapi v0.0.0-20200805222855-6aeccd4b50c6/go.mod h1:UuqjUnNftUyPE5H64/qeyjQoUZhGpeFDVdxjTeEVN2o=
372375
k8s.io/kubelet v0.19.16 h1:KJjrsTFvO6zMuMk1XIWddbq/ubcHmIDBY6YL4UPsvlo=
373376
k8s.io/kubelet v0.19.16/go.mod h1:ptskeMc0hoFMnhN/WDwCiD1WoSuRwabtNUW6fgrenUQ=

pkg/device_plugin/device_plugin.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ import (
3737
"regexp"
3838
"strings"
3939

40-
"github.com/golang/glog"
40+
klog "k8s.io/klog/v2"
4141
pluginapi "k8s.io/kubelet/pkg/apis/deviceplugin/v1beta1"
4242
)
4343

@@ -250,7 +250,7 @@ func createVgpuIDMap() {
250250
func readIDFromFileFunc(basePath string, deviceAddress string, property string) (string, error) {
251251
data, err := os.ReadFile(filepath.Join(basePath, deviceAddress, property))
252252
if err != nil {
253-
glog.Errorf("Could not read %s for device %s: %s", property, deviceAddress, err)
253+
klog.Errorf("Could not read %s for device %s: %s", property, deviceAddress, err)
254254
return "", err
255255
}
256256
id := strings.Trim(string(data[2:]), "\n")
@@ -261,7 +261,7 @@ func readIDFromFileFunc(basePath string, deviceAddress string, property string)
261261
func readLinkFunc(basePath string, deviceAddress string, link string) (string, error) {
262262
path, err := os.Readlink(filepath.Join(basePath, deviceAddress, link))
263263
if err != nil {
264-
glog.Errorf("Could not read link %s for device %s: %s", link, deviceAddress, err)
264+
klog.Errorf("Could not read link %s for device %s: %s", link, deviceAddress, err)
265265
return "", err
266266
}
267267
_, file := filepath.Split(path)
@@ -273,7 +273,7 @@ func readVgpuIDFromFileFunc(basePath string, deviceAddress string, property stri
273273
reg := regexp.MustCompile("\\s+")
274274
data, err := os.ReadFile(filepath.Join(basePath, deviceAddress, property))
275275
if err != nil {
276-
glog.Errorf("Could not read %s for device %s: %s", property, deviceAddress, err)
276+
klog.Errorf("Could not read %s for device %s: %s", property, deviceAddress, err)
277277
return "", err
278278
}
279279
str := strings.Trim(string(data[:]), "\n")
@@ -285,7 +285,7 @@ func readVgpuIDFromFileFunc(basePath string, deviceAddress string, property stri
285285
func readGpuIDForVgpuFunc(basePath string, deviceAddress string) (string, error) {
286286
path, err := os.Readlink(filepath.Join(basePath, deviceAddress))
287287
if err != nil {
288-
glog.Errorf("Could not read link for device %s: %s", deviceAddress, err)
288+
klog.Errorf("Could not read link for device %s: %s", deviceAddress, err)
289289
return "", err
290290
}
291291
splitStr := strings.Split(path, "/")

vendor/github.com/go-logr/logr/.golangci.yaml

Lines changed: 26 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/go-logr/logr/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/go-logr/logr/CONTRIBUTING.md

Lines changed: 17 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/go-logr/logr/LICENSE

Lines changed: 201 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)