Skip to content

Commit b14392e

Browse files
chore: clarified timer cleanup comment in removeTask (#326)
1 parent 966b5de commit b14392e

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

NativeScript/runtime/Timers.cpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,8 @@ class TimerState {
6565
it->second->Unschedule();
6666
timerMap_.erase(it);
6767
CFRunLoopTimerInvalidate(timer);
68-
// timer and context will be released by the retain function
69-
// CFRunLoopTimerContext context;
70-
// CFRunLoopTimerGetContext(timer, &context);
71-
// delete static_cast<std::shared_ptr<TimerTask>*>(context.info);
72-
// CFRelease(timer);
68+
// CFRunLoopTimerInvalidate triggers our TimerRelease callback, which
69+
// deletes TimerContext, whose destructor calls CFRelease(task->timer)
7370
}
7471
}
7572

0 commit comments

Comments
 (0)