resharding diag logs

Author: Sunjeet

hollow/src/main/java/com/netflix/hollow/api/client/HollowUpdatePlanner.java

@@ -113,7 +113,6 @@ public HollowUpdatePlan planUpdate(long currentVersion, HollowConsumer.VersionIn
             if(snapshotDestinationVersion == desiredVersion
                     || ((deltaDestinationVersion > desiredVersion) && (snapshotDestinationVersion < desiredVersion))
                     || ((snapshotDestinationVersion < desiredVersion) && (snapshotDestinationVersion > deltaDestinationVersion)))
-
                 return snapshotPlan;
         }
 

hollow/src/main/java/com/netflix/hollow/core/write/HollowObjectTypeWriteState.java

@@ -88,8 +88,11 @@ protected int typeStateNumShards(int maxOrdinal) {
         projectedSizeOfType += fieldStats.getTotalSizeOfAllVarLengthData();
 
         int targetNumShards = 1;
-        while(stateEngine.getTargetMaxTypeShardSize() * targetNumShards < projectedSizeOfType)
+        while(stateEngine.getTargetMaxTypeShardSize() * targetNumShards < projectedSizeOfType) {
+            LOG.info("Doubling targetNumShards from " + targetNumShards + " to " + targetNumShards*2 + " for " + getSchema().getName() + " with projected size of " + projectedSizeOfType + " and target max type shard size of " + stateEngine.getTargetMaxTypeShardSize() + " and maxOrdinal of " + maxOrdinal);
             targetNumShards *= 2;
+        }
+
 
         return targetNumShards;
     }

hollow/src/main/java/com/netflix/hollow/core/write/HollowWriteStateEngine.java

@@ -423,7 +423,7 @@ public void overrideNextStateRandomizedTag(long nextStateRandomizedTag) {
      * @param targetMaxTypeShardSize the target max type shard size, in bytes
      */
     public void setTargetMaxTypeShardSize(long targetMaxTypeShardSize) {
-        if (targetMaxTypeShardSize < 0) {
+        if (targetMaxTypeShardSize <= 0) {
             throw new IllegalArgumentException("Invalid target max shard size specified: " + targetMaxTypeShardSize);
         }
         this.targetMaxTypeShardSize = targetMaxTypeShardSize;