Skip to content

Internal detection of nix binary path is inconsistent after Nix 2.29 #47

@getchoo

Description

@getchoo

Note

This is a copy of DeterminateSystems#1672

Since the component split of Nix 2.29, /nix/store may now contain multiple paths matching the nix-* glob used here:

let nix_pkg_glob = format!("{}/nix-*/store/*-nix-*.*.*", unpacked_path.display());

This creates issues when the first result is a component's store path (like nix-main) that does not contain a binary, which can happen in release tarballs like the Linux one from this upstream CI run

Thankfully this is currently limited to users manually setting --nix-package-url - as it doesn't seem this case has ever hit the release tarballs bundled with the installer - but I wouldn't be surprised if this would affect development later down the line...

I discovered this by implementing this installer into Nix's dogfed installer tests in NixOS/nix#14002

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions