Merge pull request #7698 from NomicFoundation/typechain-imports-hardhat-ethers

Add `hardhat-ethers` to the mocha+ethers devDependencies

Author: alcuadrado

.changeset/gentle-seals-tan.md

@@ -0,0 +1,5 @@
+---
+"hardhat": patch
+---
+
+Fix the initialization of the Mocha and Ethers sample project when using pnpm

pnpm-lock.yaml

@@ -12,29 +12,40 @@ describe("hardhat-toolbox-mocha-ethers", function () {
     useFixtureProject("toolbox");
 
     it("should not throw because all the plugins should exist", async function () {
-      const hardhatConfig = await import(
-        pathToFileURL(path.join(process.cwd(), "hardhat.config.js")).href
-      );
-
-      const hre = await createHardhatRuntimeEnvironment(hardhatConfig.default);
-
-      // This will check that the node test runner is available
-      assert.notEqual(hre.tasks.getTask(["test", "mocha"]), undefined);
-
-      // This will check that ethers, chai and network helpers are available
-      await hre.tasks.getTask(["run"]).run({ script: "scripts/script.ts" });
-
-      // This will check that the keystore is available
-      assert.notEqual(hre.tasks.getTask(["keystore", "list"]), undefined);
-
-      // This will check that ignition is available
-      assert.notEqual(hre.tasks.getTask(["ignition"]), undefined);
-
-      // This will check that typechain is available
-      await remove(path.join(process.cwd(), "types")); // Be sure the folder doesn't exist
-      await hre.tasks.getTask(["build"]).run();
-      await exists(path.join(process.cwd(), "types"));
-      await remove(path.join(process.cwd(), "types"));
+      try {
+        const hardhatConfig = await import(
+          pathToFileURL(path.join(process.cwd(), "hardhat.config.js")).href
+        );
+
+        const hre = await createHardhatRuntimeEnvironment(
+          hardhatConfig.default,
+        );
+
+        // This will check that the node test runner is available
+        assert.notEqual(hre.tasks.getTask(["test", "mocha"]), undefined);
+
+        // This will check that ethers, chai and network helpers are available
+        await hre.tasks.getTask(["run"]).run({ script: "scripts/script.ts" });
+
+        // This will check that the keystore is available
+        assert.notEqual(hre.tasks.getTask(["keystore", "list"]), undefined);
+
+        // This will check that ignition is available
+        assert.notEqual(hre.tasks.getTask(["ignition"]), undefined);
+
+        // This will check that typechain is available
+        await remove(path.join(process.cwd(), "types")); // Be sure the folder doesn't exist
+
+        await hre.tasks.getTask(["build"]).run();
+        assert.equal(await exists(path.join(process.cwd(), "types")), true);
+      } finally {
+        // We need to make sure we remove it, because the generated files
+        // don't compile with --isolatedDeclarations and otherwise break the
+        // build process
+        if (await exists(path.join(process.cwd(), "types"))) {
+          await remove(path.join(process.cwd(), "types"));
+        }
+      }
     });
   });
 });

v-next/hardhat-toolbox-mocha-ethers/test/index.ts

@@ -7,6 +7,7 @@
   "devDependencies": {
     "hardhat": "workspace:^3.0.14",
     "@nomicfoundation/hardhat-toolbox-mocha-ethers": "workspace:^3.0.1",
+    "@nomicfoundation/hardhat-ethers": "workspace:^4.0.2",
     "@nomicfoundation/hardhat-ignition": "workspace:^3.0.5",
     "@types/chai": "^4.2.0",
     "@types/chai-as-promised": "^8.0.1",