Ability to tell hardhat about external artifacts so it can reverse lookup abi for errors, etc...

[wighawag]

Describe the feature

Right now, with external artifact hardhat produce errors like this :

eth_estimateGas                                                                                                                                                                                                                               
  Contract call:       <UnrecognizedContract>                                                                                                                                                                                                 
  From:                0x9f16c535a9cfdd6aebdb77271f45321b9793de42                                                                                                                                                                             
  To:                  0xa513e6e4b8f2a923d98304ec87f64353c4d5c853                                                                                                                                                                             
  Value:               0 ETH                                                                                                                                                                                                                  
                                                                                                                                                                                                                                              
  Error: VM Exception while processing transaction: reverted with an unrecognized custom error (return data: 0x954de334976ea74026e726554db657fa54763abd0c3a0aa997357df516350c68f9519135)       

This is because hardhat have no way to know about the abi, as it only see the bytecode

if we could have a way of telling hardhat about external artifacts, that would be useful

Search terms

No response

[kanej]

Hey @wighawag, thanks for opening the issue. Can I dig in a bit to understand better?

Is the issue that you can deploy a contract (or call a create2 factory etc) against a running Hardhat node, and you can do that from scripts and tests. However you can't at the same time register the ABI for the deployed contract, hence reducing the dev experience (e.g. the display of errors is generic rather than building on the ABI information)?

[wighawag]

yes, basically I do not get decoded errors in the console

I am using external artifacts, not generated by the current hardhat project and I expect to still be able to see the decoded error provided there is mechanism to tell hardhat about these external artifacts

The error I output comes from a running hardhat node, but the same would be useful for test, etc...

[michalbrabec]

At the moment, we are compiling all contracts before we run other tasks.
We are then checking the existence of the built artefacts (ABI mainly) and the original Solidity code as well

• One approach might be to avoid checking for the original contract and deploy / interact with the contract based on the ABI only.
• Another approach would be to design a new API that would allow users to inject ABIs from the project, but that would still require removing the need to resolve the Solidity code

HardhatError: HHE1000: Artifact for contract "Counter" not found. 
    at ArtifactManagerImplementation.#throwNotFoundError (/Users/michalbrabec/project/hardhat_test/node_modules/.pnpm/hardhat@3.0.6/node_modules/hardhat/src/internal/builtin-plugins/artifacts/artifact-manager.ts:215:11)
    at ArtifactManagerImplementation.#getFullyQualifiedName (/Users/michalbrabec/project/hardhat_test/node_modules/.pnpm/hardhat@3.0.6/node_modules/hardhat/src/internal/builtin-plugins/artifacts/artifact-manager.ts:174:31)
    at async ArtifactManagerImplementation.getArtifactPath (/Users/michalbrabec/project/hardhat_test/node_modules/.pnpm/hardhat@3.0.6/node_modules/hardhat/src/internal/builtin-plugins/artifacts/artifact-manager.ts:63:17)
    at async ArtifactManagerImplementation.readArtifact (/Users/michalbrabec/project/hardhat_test/node_modules/.pnpm/hardhat@3.0.6/node_modules/hardhat/src/internal/builtin-plugins/artifacts/artifact-manager.ts:53:26)
    at async validateNamedContractDeployment (/Users/michalbrabec/project/hardhat_test/node_modules/.pnpm/@nomicfoundation+ignition-core@3.0.3/node_modules/@nomicfoundation/ignition-core/src/internal/validation/futures/validateNamedContractDeployment.ts:31:20)
    at async validate (/Users/michalbrabec/project/hardhat_test/node_modules/.pnpm/@nomicfoundation+ignition-core@3.0.3/node_modules/@nomicfoundation/ignition-core/src/internal/validation/validate.ts:35:30)
    at async deploy (/Users/michalbrabec/project/hardhat_test/node_modules/.pnpm/@nomicfoundation+ignition-core@3.0.3/node_modules/@nomicfoundation/ignition-core/src/deploy.ts:95:28)
    at async taskDeploy (/Users/michalbrabec/project/hardhat_test/node_modules/.pnpm/@nomicfoundation+hardhat-ignition@3.0.3_@nomicfoundation+hardhat-verify@3.0.2_hardhat@3.0.6__hardhat@3.0.6/node_modules/@nomicfoundation/hardhat-ignition/dist/src/internal/tasks/deploy.js:111:20)
    at async Promise.all (index 0)
    at async main (/Users/michalbrabec/project/hardhat_test/node_modules/.pnpm/hardhat@3.0.6/node_modules/hardhat/src/internal/cli/main.ts:220:5)

[wighawag]

yes having solidity code optional would be great as I expect some artfiacts won't have that information ?

But for the external artifact I am using, I actually have access to the solidity code too, so if the api would also allow providing solidity code that would be great as we could have the exact position in source code as information too