Skip to content

Commit b24c03a

Browse files
chunfantasybencefr
authored andcommitted
Feature/react bootstrap 4 (#38)
* Updated babel configuration * Update style to SASS * Update dependencies * Update for new eslint rules and react-bootstrap * Update jquery according to security alert * Update devdep to ^3.0.0
1 parent ecc0107 commit b24c03a

File tree

6 files changed

+60
-42
lines changed

6 files changed

+60
-42
lines changed

.babelrc

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
{
2-
"presets": [ "react" ],
2+
"presets": [ "@babel/preset-react" ],
33
"plugins": [
44
"add-module-exports",
5-
"transform-class-properties",
6-
"transform-es2015-destructuring",
7-
"transform-es2015-modules-commonjs",
8-
"transform-es2015-parameters",
9-
"transform-es2015-spread",
10-
"transform-object-rest-spread"
5+
"@babel/plugin-proposal-class-properties",
6+
"@babel/plugin-transform-destructuring",
7+
"@babel/plugin-transform-modules-commonjs",
8+
"@babel/plugin-transform-parameters",
9+
"@babel/plugin-transform-spread",
10+
"@babel/plugin-proposal-object-rest-spread"
1111
]
1212
}

components/Chart.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,9 @@ const arrayConverter = (arr, separate) => {
7171
};
7272

7373
const Chart = props => {
74-
const { rssi, rssiMax, animationDuration, yMin, yMax, separateFrequencies } = props;
74+
const {
75+
rssi, rssiMax, animationDuration, yMin, yMax, separateFrequencies,
76+
} = props;
7577
const sep = separateFrequencies ? 'separated' : 'continuous';
7678
const rssiData = arrayConverter(rssi, separateFrequencies);
7779
const rssiMaxData = arrayConverter(rssiMax, separateFrequencies);

components/ControlPanel.jsx

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@
3737
import React from 'react';
3838
import PropTypes from 'prop-types';
3939
import ReactBootstrapSlider from 'react-bootstrap-slider';
40-
import { Checkbox, Button } from 'react-bootstrap';
40+
import Button from 'react-bootstrap/Button';
41+
import Form from 'react-bootstrap/Form';
4142

4243
const ControlPanel = props => {
4344
const {
@@ -52,7 +53,7 @@ const ControlPanel = props => {
5253
} = props;
5354
const sliderDisabled = disabled ? 'disabled' : null;
5455
return (
55-
<div >
56+
<Form>
5657
Sweep Delay (ms)<br />
5758
<ReactBootstrapSlider
5859
value={10}
@@ -93,20 +94,24 @@ const ControlPanel = props => {
9394
ticks_labels={['10', '1000']}
9495
disabled={sliderDisabled}
9596
/>
96-
<Checkbox
97-
disabled={disabled}
98-
onChange={event => onScanAdvertisementsToggle(event.target.checked)}
99-
>
100-
Advertisements only
101-
</Checkbox>
102-
<Checkbox
103-
disabled={disabled}
104-
onChange={event => onSeparateFrequencies(event.target.checked)}
105-
>
106-
Separate Frequencies
107-
</Checkbox>
97+
<Form.Group controlId="advCheck">
98+
<Form.Check
99+
disabled={disabled}
100+
onChange={event => onScanAdvertisementsToggle(event.target.checked)}
101+
type="checkbox"
102+
label="Advertisements only"
103+
/>
104+
</Form.Group>
105+
<Form.Group controlId="freqCheck">
106+
<Form.Check
107+
disabled={disabled}
108+
onChange={event => onSeparateFrequencies(event.target.checked)}
109+
type="checkbox"
110+
label="Separate Frequencies"
111+
/>
112+
</Form.Group>
108113
<Button disabled={disabled} onClick={onToggleLED}>Toggle LED</Button>
109-
</div>
114+
</Form>
110115
);
111116
};
112117

index.jsx

Lines changed: 24 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ import Chart from './components/Chart';
4343
import ControlPanel from './components/ControlPanel';
4444
import reduceApp from './reducers/appReducer';
4545
import * as RssiActions from './actions/rssiActions';
46-
import './resources/css/index.less';
46+
import './resources/css/index.scss';
4747

4848
const yRange = {
4949
min: -110,
@@ -75,17 +75,26 @@ export default {
7575
)
7676
),
7777
decorateSidePanel: SidePanel => (
78-
props => (
78+
({
79+
onDelayChange,
80+
onMaxScansChange,
81+
onChannelScanRepeatChange,
82+
onAnimationDurationChange,
83+
onScanAdvertisementsToggle,
84+
onSeparateFrequencies,
85+
onToggleLED,
86+
disabled,
87+
}) => (
7988
<SidePanel>
8089
<ControlPanel
81-
onDelayChange={props.onDelayChange}
82-
onMaxScansChange={props.onMaxScansChange}
83-
onChannelScanRepeatChange={props.onChannelScanRepeatChange}
84-
onAnimationDurationChange={props.onAnimationDurationChange}
85-
onScanAdvertisementsToggle={props.onScanAdvertisementsToggle}
86-
onSeparateFrequencies={props.onSeparateFrequencies}
87-
onToggleLED={props.onToggleLED}
88-
disabled={props.disabled}
90+
onDelayChange={onDelayChange}
91+
onMaxScansChange={onMaxScansChange}
92+
onChannelScanRepeatChange={onChannelScanRepeatChange}
93+
onAnimationDurationChange={onAnimationDurationChange}
94+
onScanAdvertisementsToggle={onScanAdvertisementsToggle}
95+
onSeparateFrequencies={onSeparateFrequencies}
96+
onToggleLED={onToggleLED}
97+
disabled={disabled}
8998
/>
9099
</SidePanel>
91100
)
@@ -95,13 +104,15 @@ export default {
95104
onDelayChange: delay => dispatch(RssiActions.setDelay(delay)),
96105
onMaxScansChange: maxScans => dispatch(RssiActions.setMaxScans(maxScans)),
97106
onChannelScanRepeatChange: scanRepeat => dispatch(
98-
RssiActions.setScanRepeatTimes(scanRepeat)),
107+
RssiActions.setScanRepeatTimes(scanRepeat),
108+
),
99109
onAnimationDurationChange: animationDuration => dispatch({
100110
type: 'RSSI_CHANGE_ANIMATION_DURATION',
101111
animationDuration,
102112
}),
103113
onScanAdvertisementsToggle: scanAdvertisementChannels => dispatch(
104-
RssiActions.scanAdvertisementChannels(scanAdvertisementChannels)),
114+
RssiActions.scanAdvertisementChannels(scanAdvertisementChannels),
115+
),
105116
onSeparateFrequencies: separateFrequencies => dispatch({
106117
type: 'RSSI_SEPARATE_FREQUENCIES',
107118
separateFrequencies,
@@ -112,7 +123,7 @@ export default {
112123
disabled: state.app.port === null,
113124
...props,
114125
}),
115-
mapSerialPortSelectorState: (state, props) => ({
126+
mapDeviceSelectorState: (state, props) => ({
116127
portIndicatorStatus: (state.app.port !== null) ? 'on' : 'off',
117128
...props,
118129
}),

package.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@
3131
"clean-modules": "rimraf \"node_modules/!(rimraf|.bin)\""
3232
},
3333
"devDependencies": {
34-
"bootstrap": "4.1.0",
35-
"chart.js": "2.7.2",
36-
"jquery": "3.3.1",
37-
"pc-nrfconnect-devdep": "git+https://github.com/NordicSemiconductor/pc-nrfconnect-devdep.git#semver:^1.3.0",
38-
"react-bootstrap-slider": "2.1.4",
39-
"react-chartjs-2": "2.7.0"
34+
"bootstrap": "4.3.1",
35+
"chart.js": "2.7.3",
36+
"jquery": "3.4.0",
37+
"pc-nrfconnect-devdep": "git+https://github.com/NordicSemiconductor/pc-nrfconnect-devdep.git#semver:^3.0.0",
38+
"react-bootstrap-slider": "2.2.2",
39+
"react-chartjs-2": "2.7.4"
4040
},
4141
"dependencies": {},
4242
"engines": {

0 commit comments

Comments
 (0)