Skip to content

Commit 7f04fa3

Browse files
Merge pull request #1081 from NordicSemiconductor/push-mtvoznrkvrzs
Support using logger in launcher
2 parents d635e16 + c846006 commit 7f04fa3

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

Changelog.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,13 @@ This project does _not_ adhere to
77
[Semantic Versioning](https://semver.org/spec/v2.0.0.html) but contrary to it
88
every new version is a new major version.
99

10+
## 237.0.0 - 2025-11-12
11+
12+
### Changed
13+
14+
- The logger now also supports being used in the renderer process of the
15+
launcher.
16+
1017
## 236.0.0 - 2025-11-07
1118

1219
### Changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nordicsemiconductor/pc-nrfconnect-shared",
3-
"version": "236.0.0",
3+
"version": "237.0.0",
44
"description": "Shared commodities for developing pc-nrfconnect-* packages",
55
"repository": {
66
"type": "git",

src/logging/index.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@ import { SPLAT } from 'triple-beam';
99
import { createLogger, format, LogEntry, Logger, transports } from 'winston';
1010
import Transport from 'winston-transport';
1111

12-
import { getAppLogDir } from '../utils/appDirs';
12+
import { getAppLogDir, getUserDataDir } from '../utils/appDirs';
1313
import { openFile, openFileLocation } from '../utils/open';
14+
import { isLauncher } from '../utils/packageJson';
1415
import AppTransport from './appTransport';
1516
import describeError from './describeError';
1617
import createLogBuffer from './logBuffer';
@@ -27,7 +28,11 @@ const isConsoleAvailable = (() => {
2728
})();
2829

2930
const filePrefix = new Date().toISOString().replace(/:/gi, '_');
30-
const logFilePath = () => path.join(getAppLogDir(), `${filePrefix}-log.txt`);
31+
32+
const logFilePath = () =>
33+
isLauncher()
34+
? path.join(getUserDataDir(), 'logs', 'renderer.log')
35+
: path.join(getAppLogDir(), `${filePrefix}-log.txt`);
3136

3237
const logBuffer = createLogBuffer();
3338

0 commit comments

Comments
 (0)