Skip to content

Conversation

@ced4rtree
Copy link

#1246 Introduced a couple CI failures. Firstly, the docs were formatted improperly such that there was no newline between the change added and the next author. Secondly, the PR changed the name of the hop plugin from "hop-nvim" to "hop.nvim," but didn't update this value in vim.startPlugins in the hop module.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

Resolves a typo introduced in NotAShelf#1246 that was causing CI to fail
Couldn't build the nix package since NotAShelf#1246 changed the plugin name to
hop.nvim, but didn't update hop/config.nix to use that
@github-actions
Copy link

github-actions bot commented Nov 28, 2025

🚀 Live preview deployed from 43b4890

View it here:

Debug Information

Triggered by: horriblename

HEAD at: ci/fix-1246

Reruns: 1633

Copy link
Collaborator

@horriblename horriblename left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@horriblename horriblename merged commit 43b4890 into NotAShelf:v0.8 Dec 4, 2025
14 checks passed
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

✅ Preview has been deleted successfully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants