refactor-enforced-Number-namespace (#2536)

* refactor-enforced-Number-namespace

* Add eslint rules

---------

Co-authored-by: Arkadii Yakovets <[email protected]>

Author: kart-u

frontend/__tests__/unit/components/AnimatedCounter.test.tsx

@@ -71,7 +71,7 @@ describe('AnimatedCounter', () => {
       })
 
       // Should show intermediate value
-      const displayedValue = parseInt(screen.getByText(/\d+/).textContent || '0')
+      const displayedValue = Number.parseInt(screen.getByText(/\d+/).textContent || '0')
       expect(displayedValue).toBeGreaterThan(0)
       expect(displayedValue).toBeLessThanOrEqual(50)
     })

frontend/__tests__/unit/components/SearchPageLayout.test.tsx

@@ -251,7 +251,7 @@ describe('<SearchPageLayout />', () => {
       <SearchPageLayout
         isLoaded={true}
         totalPages={3}
-        currentPage={NaN}
+        currentPage={Number.NaN}
         onSearch={() => {}}
         onPageChange={handlePageChange}
         searchQuery=""
@@ -346,7 +346,7 @@ describe('<SearchPageLayout />', () => {
     render(
       <SearchPageLayout
         isLoaded={true}
-        totalPages={NaN}
+        totalPages={Number.NaN}
         currentPage={1}
         onSearch={() => {}}
         onPageChange={() => {}}

frontend/eslint-rules/no-global-isfinite.mjs

@@ -0,0 +1,31 @@
+const noGlobalIsFiniteRule = {
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'Disallow use of global isFinite, use Number.isFinite instead',
+      recommended: false,
+    },
+    fixable: 'code',
+    messages: {
+      useNumberIsFinite: 'Use Number.isFinite() instead of global isFinite().',
+    },
+    schema: [],
+  },
+  create(context) {
+    return {
+      CallExpression(node) {
+        if (node.callee.type === 'Identifier' && node.callee.name === 'isFinite') {
+          context.report({
+            node: node.callee,
+            messageId: 'useNumberIsFinite',
+            fix(fixer) {
+              return fixer.replaceText(node.callee, 'Number.isFinite')
+            },
+          })
+        }
+      },
+    }
+  },
+}
+
+export default noGlobalIsFiniteRule

frontend/eslint-rules/no-global-isnan.mjs

@@ -0,0 +1,31 @@
+const noGlobalIsNaNRule = {
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'Disallow use of global isNaN, use Number.isNaN instead',
+      recommended: false,
+    },
+    fixable: 'code',
+    messages: {
+      useNumberIsNaN: 'Use Number.isNaN() instead of global isNaN().',
+    },
+    schema: [],
+  },
+  create(context) {
+    return {
+      CallExpression(node) {
+        if (node.callee.type === 'Identifier' && node.callee.name === 'isNaN') {
+          context.report({
+            node: node.callee,
+            messageId: 'useNumberIsNaN',
+            fix(fixer) {
+              return fixer.replaceText(node.callee, 'Number.isNaN')
+            },
+          })
+        }
+      },
+    }
+  },
+}
+
+export default noGlobalIsNaNRule

frontend/eslint-rules/no-global-nan.mjs

@@ -0,0 +1,44 @@
+const noGlobalNaNRule = {
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'Disallow use of global NaN, use Number.NaN instead',
+      recommended: false,
+    },
+    fixable: 'code',
+    messages: {
+      useNumberNaN: 'Use Number.NaN instead of global NaN.',
+    },
+    schema: [],
+  },
+  create(context) {
+    return {
+      Identifier(node) {
+        // Only report if it's 'NaN' and not already part of 'Number.NaN'
+        if (node.name === 'NaN') {
+          const parent = node.parent
+          if (
+            parent &&
+            parent.type === 'MemberExpression' &&
+            parent.property === node &&
+            parent.object &&
+            parent.object.type === 'Identifier' &&
+            parent.object.name === 'Number'
+          ) {
+            return
+          }
+
+          context.report({
+            node,
+            messageId: 'useNumberNaN',
+            fix(fixer) {
+              return fixer.replaceText(node, 'Number.NaN')
+            },
+          })
+        }
+      },
+    }
+  },
+}
+
+export default noGlobalNaNRule

frontend/eslint-rules/no-global-parsefloat.mjs

@@ -0,0 +1,31 @@
+const noGlobalParseFloatRule = {
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'Disallow use of global parseFloat, use Number.parseFloat instead',
+      recommended: false,
+    },
+    fixable: 'code',
+    messages: {
+      useNumberParseFloat: 'Use Number.parseFloat() instead of global parseFloat().',
+    },
+    schema: [],
+  },
+  create(context) {
+    return {
+      CallExpression(node) {
+        if (node.callee.type === 'Identifier' && node.callee.name === 'parseFloat') {
+          context.report({
+            node: node.callee,
+            messageId: 'useNumberParseFloat',
+            fix(fixer) {
+              return fixer.replaceText(node.callee, 'Number.parseFloat')
+            },
+          })
+        }
+      },
+    }
+  },
+}
+
+export default noGlobalParseFloatRule

frontend/eslint-rules/no-global-parseint.mjs

@@ -0,0 +1,31 @@
+const noGlobalParseIntRule = {
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'Disallow use of global parseInt, use Number.parseInt instead',
+      recommended: false,
+    },
+    fixable: 'code',
+    messages: {
+      useNumberParseInt: 'Use Number.parseInt() instead of global parseInt().',
+    },
+    schema: [],
+  },
+  create(context) {
+    return {
+      CallExpression(node) {
+        if (node.callee.type === 'Identifier' && node.callee.name === 'parseInt') {
+          context.report({
+            node: node.callee,
+            messageId: 'useNumberParseInt',
+            fix(fixer) {
+              return fixer.replaceText(node.callee, 'Number.parseInt')
+            },
+          })
+        }
+      },
+    }
+  },
+}
+
+export default noGlobalParseIntRule

frontend/eslint.config.mjs

@@ -15,6 +15,11 @@ import react from 'eslint-plugin-react'
 import reactHooks from 'eslint-plugin-react-hooks'
 import nextPlugin from '@next/eslint-plugin-next'
 import globals from 'globals'
+import noGlobalIsFiniteRule from './eslint-rules/no-global-isfinite.mjs'
+import noGlobalIsNaNRule from './eslint-rules/no-global-isnan.mjs'
+import noGlobalNaNRule from './eslint-rules/no-global-nan.mjs'
+import noGlobalParseFloatRule from './eslint-rules/no-global-parsefloat.mjs'
+import noGlobalParseIntRule from './eslint-rules/no-global-parseint.mjs'
 
 const __filename = fileURLToPath(import.meta.url)
 const __dirname = dirname(__filename)
@@ -61,6 +66,15 @@ const eslintConfig = [
       react,
       'jsx-a11y': jsxA11y,
       '@next/next': nextPlugin,
+      nest: {
+        rules: {
+          'no-global-isfinite': noGlobalIsFiniteRule,
+          'no-global-isnan': noGlobalIsNaNRule,
+          'no-global-nan': noGlobalNaNRule,
+          'no-global-parsefloat': noGlobalParseFloatRule,
+          'no-global-parseint': noGlobalParseIntRule,
+        },
+      },
     },
     settings: {
       'import/resolver': {
@@ -149,6 +163,11 @@ const eslintConfig = [
       'jsx-a11y/no-distracting-elements': 'warn',
       'jsx-a11y/label-has-associated-control': 'error',
       'jsx-a11y/click-events-have-key-events': 'warn',
+      'nest/no-global-isfinite': 'error',
+      'nest/no-global-isnan': 'error',
+      'nest/no-global-nan': 'error',
+      'nest/no-global-parsefloat': 'error',
+      'nest/no-global-parseint': 'error',
     },
   },
   {

frontend/src/app/my/mentorship/page.tsx

@@ -24,7 +24,7 @@ const MyMentorshipPage: React.FC = () => {
   const username = (session as ExtendedSession)?.user?.login
 
   const initialQuery = searchParams.get('q') || ''
-  const initialPage = parseInt(searchParams.get('page') || '1', 10)
+  const initialPage = Number.parseInt(searchParams.get('page') || '1', 10)
 
   const [searchQuery, setSearchQuery] = useState(initialQuery)
   const [debouncedQuery, setDebouncedQuery] = useState(initialQuery)

frontend/src/components/ModuleCard.tsx

@@ -98,7 +98,7 @@ export default ModuleCard
 export const getSimpleDuration = (start: string, end: string): string => {
   const startDate = new Date(start)
   const endDate = new Date(end)
-  if (isNaN(startDate.getTime()) || isNaN(endDate.getTime())) {
+  if (Number.isNaN(startDate.getTime()) || Number.isNaN(endDate.getTime())) {
     return 'Invalid duration'
   }