Skip to content

Conversation

@P3tra-WP
Copy link
Collaborator

Added hashicorp vault threat model and its entry into the index.json

@jgadsden jgadsden added the enhancement New feature or request label Oct 14, 2025
@jgadsden jgadsden self-requested a review October 14, 2025 13:57
Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good and the files pass the schema checks

threat-model-library % check-jsonschema --schemafile threat-model.schema.json threat-models/infrastructure/hashicorp-vault-threat-model.json
ok -- validation done
threat-model-library % check-jsonschema --schemafile index.schema.json index.json 
ok -- validation done

shall I go ahead and merge @P3tra-WP ?

@jgadsden
Copy link
Collaborator

Going ahead with the merge @P3tra-WP , I hope that is OK with you

@P3tra-WP
Copy link
Collaborator Author

P3tra-WP commented Oct 19, 2025

its still failing a check - why do you think it is? @jgadsden

@jgadsden
Copy link
Collaborator

its still failing a check - why do you think it is? @jgadsden

This branch was created before the pull request workflow bug was fixed, and so it will fail until merged in
The model itself and the index file pass the schema checks so it is safe to merge this model in

@jmehnle
Copy link
Collaborator

jmehnle commented Oct 20, 2025

We can just rebase the branch, and it should benefit from the updated workflow.

@jmehnle jmehnle force-pushed the threat-model/infrastructure/hashicorp-vault branch from 6354da2 to edd2426 Compare October 20, 2025 01:22
@jmehnle
Copy link
Collaborator

jmehnle commented Oct 20, 2025

You guys go ahead and merge when you're comfortable! 🚀

@jgadsden
Copy link
Collaborator

You guys go ahead and merge when you're comfortable! 🚀

Thanks @jmehnle , going ahead with the merge

@jgadsden jgadsden merged commit a458985 into main Oct 21, 2025
3 checks passed
@jgadsden jgadsden deleted the threat-model/infrastructure/hashicorp-vault branch October 21, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants