-
Notifications
You must be signed in to change notification settings - Fork 6
Threat model/infrastructure/hashicorp vault #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jgadsden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good and the files pass the schema checks
threat-model-library % check-jsonschema --schemafile threat-model.schema.json threat-models/infrastructure/hashicorp-vault-threat-model.json
ok -- validation done
threat-model-library % check-jsonschema --schemafile index.schema.json index.json
ok -- validation done
shall I go ahead and merge @P3tra-WP ?
|
Going ahead with the merge @P3tra-WP , I hope that is OK with you |
|
its still failing a check - why do you think it is? @jgadsden |
This branch was created before the pull request workflow bug was fixed, and so it will fail until merged in |
|
We can just rebase the branch, and it should benefit from the updated workflow. |
… risks, and some corrections that came from validation
6354da2 to
edd2426
Compare
|
You guys go ahead and merge when you're comfortable! 🚀 |
Thanks @jmehnle , going ahead with the merge |
Added hashicorp vault threat model and its entry into the index.json