Merge pull request #584 from OneBusAway/release-please--branches--main--changes--next

release: 1.1.2

Author: Ahmedhossamdev

.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "1.1.1"
+  ".": "1.1.2"
 }

.rubocop.yml

@@ -121,6 +121,10 @@ Metrics/BlockLength:
 Metrics/ClassLength:
   Enabled: false
 
+Metrics/CollectionLiteralLength:
+  Exclude:
+    - "test/**/*"
+
 Metrics/CyclomaticComplexity:
   Enabled: false
 

CHANGELOG.md

@@ -1,5 +1,29 @@
 # Changelog
 
+## 1.1.2 (2025-10-15)
+
+Full Changelog: [v1.1.1...v1.1.2](https://github.com/OneBusAway/ruby-sdk/compare/v1.1.1...v1.1.2)
+
+### Bug Fixes
+
+* always send `filename=...` for multipart requests where a file is expected ([ae0a463](https://github.com/OneBusAway/ruby-sdk/commit/ae0a4631df4a0ba4ebb386e4bcd228977b8554c3))
+* coroutine leaks from connection pool ([5c3a6f1](https://github.com/OneBusAway/ruby-sdk/commit/5c3a6f121a63c3046f39ce62fba651a5e4e57ba8))
+* shorten multipart boundary sep to less than RFC specificed max length ([eee0939](https://github.com/OneBusAway/ruby-sdk/commit/eee0939d23255dbd6b3de367bbba02ea0a346425))
+* should not reuse buffers for `IO.copy_stream` interop ([29dd5d7](https://github.com/OneBusAway/ruby-sdk/commit/29dd5d7e0bcfbaf3027fca84a6338c37131843e6))
+
+
+### Performance Improvements
+
+* faster code formatting ([95c9921](https://github.com/OneBusAway/ruby-sdk/commit/95c99210f84f729076f9c6494a98729946bcb7d9))
+
+
+### Chores
+
+* allow fast-format to use bsd sed as well ([ac285dc](https://github.com/OneBusAway/ruby-sdk/commit/ac285dcaff516a5d8755da3534f83dfa588bcb6d))
+* ignore linter error for tests having large collections ([88b7a09](https://github.com/OneBusAway/ruby-sdk/commit/88b7a092d8bab6f77ee3fdc351e0b7d0fe41713a))
+* improve example values ([c2ea3c6](https://github.com/OneBusAway/ruby-sdk/commit/c2ea3c65ba37c82b323cffafad37b17b10d04c3b))
+* **internal:** codegen related update ([2a3af55](https://github.com/OneBusAway/ruby-sdk/commit/2a3af55696978980ca69da2e42caecf15c72ba2d))
+
 ## 1.1.1 (2025-09-20)
 
 Full Changelog: [v1.1.0...v1.1.1](https://github.com/OneBusAway/ruby-sdk/compare/v1.1.0...v1.1.1)

Gemfile.lock

@@ -11,7 +11,7 @@ GIT
 PATH
   remote: .
   specs:
-    onebusaway-sdk (1.1.1)
+    onebusaway-sdk (1.1.2)
       connection_pool
 
 GEM

README.md

@@ -17,7 +17,7 @@ To use this gem, install via Bundler by adding the following to your application
 <!-- x-release-please-start-version -->
 
 ```ruby
-gem "onebusaway-sdk", "~> 1.1.1"
+gem "onebusaway-sdk", "~> 1.1.2"
 ```
 
 <!-- x-release-please-end -->

Rakefile

@@ -12,6 +12,8 @@ tapioca = "sorbet/tapioca"
 examples = "examples"
 ignore_file = ".ignore"
 
+FILES_ENV = "FORMAT_FILE"
+
 CLEAN.push(*%w[.idea/ .ruby-lsp/ .yardoc/ doc/], *FileList["*.gem"], ignore_file)
 
 CLOBBER.push(*%w[sorbet/rbi/annotations/ sorbet/rbi/gems/], tapioca)
@@ -38,6 +40,14 @@ end
 xargs = %w[xargs --no-run-if-empty --null --max-procs=0 --max-args=300 --]
 ruby_opt = {"RUBYOPT" => [ENV["RUBYOPT"], "--encoding=UTF-8"].compact.join(" ")}
 
+filtered = ->(ext, dirs) do
+  if ENV.key?(FILES_ENV)
+    %w[sed -E -n -e] << "/\\.#{ext}$/p" << "--" << ENV.fetch(FILES_ENV)
+  else
+    (%w[find] + dirs + %w[-type f -and -name]) << "*.#{ext}" << "-print0"
+  end
+end
+
 desc("Lint `*.rb(i)`")
 multitask(:"lint:rubocop") do
   find = %w[find ./lib ./test ./rbi ./examples -type f -and ( -name *.rb -or -name *.rbi ) -print0]
@@ -52,24 +62,26 @@ multitask(:"lint:rubocop") do
   sh("#{find.shelljoin} | #{lint.shelljoin}")
 end
 
+norm_lines = %w[tr -- \n \0].shelljoin
+
 desc("Format `*.rb`")
 multitask(:"format:rb") do
   # while `syntax_tree` is much faster than `rubocop`, `rubocop` is the only formatter with full syntax support
-  find = %w[find ./lib ./test ./examples -type f -and -name *.rb -print0]
+  files = filtered["rb", %w[./lib ./test ./examples]]
   fmt = xargs + %w[rubocop --fail-level F --autocorrect --format simple --]
-  sh("#{find.shelljoin} | #{fmt.shelljoin}")
+  sh("#{files.shelljoin} | #{norm_lines} | #{fmt.shelljoin}")
 end
 
 desc("Format `*.rbi`")
 multitask(:"format:rbi") do
-  find = %w[find ./rbi -type f -and -name *.rbi -print0]
+  files = filtered["rbi", %w[./rbi]]
   fmt = xargs + %w[stree write --]
-  sh(ruby_opt, "#{find.shelljoin} | #{fmt.shelljoin}")
+  sh(ruby_opt, "#{files.shelljoin} | #{norm_lines} | #{fmt.shelljoin}")
 end
 
 desc("Format `*.rbs`")
 multitask(:"format:rbs") do
-  find = %w[find ./sig -type f -name *.rbs -print0]
+  files = filtered["rbs", %w[./sig]]
   inplace = /darwin|bsd/ =~ RUBY_PLATFORM ? ["-i", ""] : %w[-i]
   uuid = SecureRandom.uuid
 
@@ -98,13 +110,13 @@ multitask(:"format:rbs") do
   success = false
 
   # transform class aliases to type aliases, which syntax tree has no trouble with
-  sh("#{find.shelljoin} | #{pre.shelljoin}")
+  sh("#{files.shelljoin} | #{norm_lines} | #{pre.shelljoin}")
   # run syntax tree to format `*.rbs` files
-  sh(ruby_opt, "#{find.shelljoin} | #{fmt.shelljoin}") do
+  sh(ruby_opt, "#{files.shelljoin} | #{norm_lines} | #{fmt.shelljoin}") do
     success = _1
   end
   # transform type aliases back to class aliases
-  sh("#{find.shelljoin} | #{pst.shelljoin}")
+  sh("#{files.shelljoin} | #{norm_lines} | #{pst.shelljoin}")
 
   # always run post-processing to remove comment marker
   fail unless success

lib/onebusaway_sdk/file_part.rb

@@ -38,18 +38,21 @@ def to_json(*a) = read.to_json(*a)
     def to_yaml(*a) = read.to_yaml(*a)
 
     # @param content [Pathname, StringIO, IO, String]
-    # @param filename [String, nil]
+    # @param filename [Pathname, String, nil]
     # @param content_type [String, nil]
     def initialize(content, filename: nil, content_type: nil)
-      @content = content
+      @content_type = content_type
       @filename =
-        case content
-        in Pathname
-          filename.nil? ? content.basename.to_path : ::File.basename(filename)
+        case [filename, (@content = content)]
+        in [String | Pathname, _]
+          ::File.basename(filename)
+        in [nil, Pathname]
+          content.basename.to_path
+        in [nil, IO]
+          content.to_path
         else
-          filename.nil? ? nil : ::File.basename(filename)
+          filename
         end
-      @content_type = content_type
     end
   end
 end

lib/onebusaway_sdk/internal/transport/pooled_net_requester.rb

@@ -134,9 +134,9 @@ def execute(request)
 
           # rubocop:disable Metrics/BlockLength
           enum = Enumerator.new do |y|
-            with_pool(url, deadline: deadline) do |conn|
-              next if finished
+            next if finished
 
+            with_pool(url, deadline: deadline) do |conn|
               req, closing = self.class.build_request(request) do
                 self.class.calibrate_socket_timeout(conn, deadline)
               end
@@ -149,7 +149,7 @@ def execute(request)
 
               self.class.calibrate_socket_timeout(conn, deadline)
               conn.request(req) do |rsp|
-                y << [conn, req, rsp]
+                y << [req, rsp]
                 break if finished
 
                 rsp.read_body do |bytes|
@@ -160,6 +160,8 @@ def execute(request)
                 end
                 eof = true
               end
+            ensure
+              conn.finish if !eof && conn&.started?
             end
           rescue Timeout::Error
             raise OnebusawaySDK::Errors::APITimeoutError.new(url: url, request: req)
@@ -168,16 +170,11 @@ def execute(request)
           end
           # rubocop:enable Metrics/BlockLength
 
-          conn, _, response = enum.next
+          _, response = enum.next
           body = OnebusawaySDK::Internal::Util.fused_enum(enum, external: true) do
             finished = true
-            tap do
-              enum.next
-            rescue StopIteration
-              nil
-            end
+            loop { enum.next }
           ensure
-            conn.finish if !eof && conn&.started?
             closing&.call
           end
           [Integer(response.code), response, body]

lib/onebusaway_sdk/internal/type/file_input.rb

@@ -82,17 +82,20 @@ def coerce(value, state:)
           #
           # @return [Pathname, StringIO, IO, String, Object]
           def dump(value, state:)
-            # rubocop:disable Lint/DuplicateBranch
             case value
+            in StringIO | String
+              # https://datatracker.ietf.org/doc/html/rfc7578#section-4.2
+              # while not required, a filename is recommended, and in practice many servers do expect this
+              OnebusawaySDK::FilePart.new(value, filename: "upload")
             in IO
               state[:can_retry] = false
+              value.to_path.nil? ? OnebusawaySDK::FilePart.new(value, filename: "upload") : value
             in OnebusawaySDK::FilePart if value.content.is_a?(IO)
               state[:can_retry] = false
+              value
             else
+              value
             end
-            # rubocop:enable Lint/DuplicateBranch
-
-            value
           end
 
           # @api private

lib/onebusaway_sdk/internal/util.rb

@@ -473,10 +473,9 @@ class << self
         # @return [Enumerable<String>]
         def writable_enum(&blk)
           Enumerator.new do |y|
-            buf = String.new
             y.define_singleton_method(:write) do
-              self << buf.replace(_1)
-              buf.bytesize
+              self << _1.dup
+              _1.bytesize
             end
 
             blk.call(y)
@@ -566,7 +565,8 @@ class << self
         #
         # @return [Array(String, Enumerable<String>)]
         private def encode_multipart_streaming(body)
-          boundary = SecureRandom.urlsafe_base64(60)
+          # RFC 1521 Section 7.2.1 says we should have 70 char maximum for boundary length
+          boundary = SecureRandom.urlsafe_base64(46)
 
           closing = []
           strio = writable_enum do |y|