fix oxlint issues

Author: fadi-george

.github/workflows/ci.yml

@@ -39,8 +39,8 @@ jobs:
       - name: Install dependencies
         run: bun install --frozen-lockfile
 
-      - name: Check Code formatting
-        run: bun run format:check
+      - name: Check linting
+        run: bun run lint
 
       - name: Run tests
         run: bun run test:coverage

.oxlintrc.json

@@ -1,10 +1,6 @@
 {
   "$schema": "./node_modules/oxlint/configuration_schema.json",
-  "plugins": [
-    "unicorn",
-    "typescript",
-    "oxc"
-  ],
+  "plugins": ["unicorn", "typescript", "oxc"],
   "categories": {},
   "rules": {
     "for-direction": "warn",
@@ -50,7 +46,7 @@
     "no-unused-expressions": "warn",
     "no-unused-labels": "warn",
     "no-unused-private-class-members": "warn",
-    "no-unused-vars": "warn",
+    "no-unused-vars": "error",
     "no-useless-backreference": "warn",
     "no-useless-catch": "warn",
     "no-useless-escape": "warn",
@@ -140,4 +136,4 @@
   },
   "globals": {},
   "ignorePatterns": []
-}
+}

package.json

@@ -16,6 +16,8 @@
     "format:check:spotless": "./example/IonicCapOneSignal/android/gradlew spotlessCheck",
     "format:check:prettier": "prettier --check \"**/*.{ts,tsx}\" --ignore-path .gitignore",
     "format:check": "concurrently \"npm:format:check:spotless\" \"npm:format:check:prettier\"",
+    "lint": "oxlint ./www && bun run format:check",
+    "lint:fix": "oxlint ./www --fix && bun run format:fix",
     "test": "vitest",
     "test:coverage": "vitest run --coverage"
   },

www/InAppMessagesNamespace.test.ts

@@ -253,7 +253,7 @@ describe('InAppMessages', () => {
     });
 
     test('should resolve Promise when cordova.exec succeeds', async () => {
-      mockExec.mockImplementation((resolve, reject) => {
+      mockExec.mockImplementation((resolve) => {
         resolve(true);
       });
 

www/LocationNamespace.test.ts

@@ -46,7 +46,7 @@ describe('Location', () => {
 
   describe('isShared', () => {
     test('should return a Promise and call cordova.exec for isShared', () => {
-      mockExec.mockImplementation((resolve, reject) => {
+      mockExec.mockImplementation((resolve) => {
         resolve(true);
       });
 
@@ -64,7 +64,7 @@ describe('Location', () => {
     });
 
     test('should resolve Promise when cordova.exec succeeds', async () => {
-      mockExec.mockImplementation((resolve, reject) => {
+      mockExec.mockImplementation((resolve) => {
         resolve(true);
       });
 
@@ -75,7 +75,7 @@ describe('Location', () => {
     test('should reject Promise when cordova.exec fails', async () => {
       const mockError = new Error('Location permission denied');
 
-      mockExec.mockImplementation((resolve, reject) => {
+      mockExec.mockImplementation((_resolve, reject) => {
         reject(mockError);
       });
       await expect(location.isShared()).rejects.toThrow(mockError.message);

www/NotificationsNamespace.test.ts

@@ -20,7 +20,7 @@ describe('Notifications', () => {
 
   describe('getPermissionAsync', () => {
     test('should return a Promise and call cordova.exec for getPermissionAsync', () => {
-      mockExec.mockImplementation((resolve, reject) => {
+      mockExec.mockImplementation((resolve) => {
         resolve(true);
       });
 
@@ -38,7 +38,7 @@ describe('Notifications', () => {
     });
 
     test('should resolve Promise when cordova.exec succeeds', async () => {
-      mockExec.mockImplementation((resolve, reject) => {
+      mockExec.mockImplementation((resolve) => {
         resolve(true);
       });
 
@@ -50,7 +50,7 @@ describe('Notifications', () => {
     test('should reject Promise when cordova.exec fails', async () => {
       const mockError = new Error('Permission check failed');
 
-      mockExec.mockImplementation((resolve, reject) => {
+      mockExec.mockImplementation((_resolve, reject) => {
         reject(mockError);
       });
 
@@ -62,7 +62,7 @@ describe('Notifications', () => {
 
   describe('permissionNative', () => {
     test('should return a Promise and call cordova.exec for permissionNative', () => {
-      mockExec.mockImplementation((resolve, reject) => {
+      mockExec.mockImplementation((resolve) => {
         resolve(OSNotificationPermission.Authorized);
       });
 
@@ -81,7 +81,7 @@ describe('Notifications', () => {
     });
 
     test('should resolve with OSNotificationPermission enum value', async () => {
-      mockExec.mockImplementation((resolve, reject) => {
+      mockExec.mockImplementation((resolve) => {
         resolve(OSNotificationPermission.Authorized);
       });
 
@@ -93,7 +93,7 @@ describe('Notifications', () => {
     test('should reject Promise when cordova.exec fails', async () => {
       const mockError = new Error('Permission check failed');
 
-      mockExec.mockImplementation((resolve, reject) => {
+      mockExec.mockImplementation((_resolve, reject) => {
         reject(mockError);
       });
       await expect(notifications.permissionNative()).rejects.toThrow(
@@ -106,7 +106,7 @@ describe('Notifications', () => {
     test.each([[true], [false]])(
       'should call cordova.exec for requestPermission with fallbackToSettings %s',
       async (fallback) => {
-        mockExec.mockImplementation((resolve, reject) => {
+        mockExec.mockImplementation((resolve) => {
           resolve(true);
         });
 
@@ -123,7 +123,7 @@ describe('Notifications', () => {
     );
 
     test('should use default fallbackToSettings of false when not provided', () => {
-      mockExec.mockImplementation((resolve, reject) => {
+      mockExec.mockImplementation((resolve) => {
         resolve(true);
       });
 
@@ -143,7 +143,7 @@ describe('Notifications', () => {
 
   describe('canRequestPermission', () => {
     test('should return a Promise and call cordova.exec for canRequestPermission', () => {
-      mockExec.mockImplementation((resolve, reject) => {
+      mockExec.mockImplementation((resolve) => {
         resolve(true);
       });
 
@@ -162,7 +162,7 @@ describe('Notifications', () => {
     });
 
     test('should resolve with boolean value', async () => {
-      mockExec.mockImplementation((resolve, reject) => {
+      mockExec.mockImplementation((resolve) => {
         resolve(false);
       });